Uh oh!
There was an error while loading. Please reload this page.
Test RDRAND on x86 / x86_64 targets - #476
Closed
josephlr wants to merge 2 commits into
Closed
Conversation
Closed
newpavlov
commented
Jun 14, 2024
Member
As I wrote here, this probably can be done a bit better. |
Merged
josephlrforce-pushed
the
test_rdrand
branch
3 times, most recently
from
June 19, 2024 07:45
6238ad6 to
fb5d54cCompareSigned-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
commented
Jun 20, 2024
MemberAuthor
Closing to keep conversation in #471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #471
Now when running
cargo testwe see the additionalrdrandtests:I think the main question here is if we should unconditionally run these tests like we did before, or if we should only run them if the
"rdrand"feature is set.