Skip to content

ci: enforce that getrandom does not contain potential panics - #515

Merged
newpavlov merged 10 commits into
masterfrom
nopanic
Oct 14, 2024
Merged

ci: enforce that getrandom does not contain potential panics#515
newpavlov merged 10 commits into
masterfrom
nopanic

Conversation

@newpavlov

@newpavlovnewpavlov commented Oct 14, 2024

Copy link
Copy Markdown
Member

The check is done by compiling cdylib which exposes getrandom_uninit and checking that the result does not contain any strings with "panic".

For now CI only checks linux_android_with_fallback, linux_android, rdrand, wasi, and getentropy backends. Other backend checks could be added in future PRs.

Closes#435

@newpavlov

newpavlov commented Oct 14, 2024

Copy link
Copy Markdown
MemberAuthor

The above commits demonstrate that CI successfully detects potential panics.

@newpavlovnewpavlov changed the title Add no-panic checkci: enforce that getrandom does not contain potential panicsOct 14, 2024
@newpavlov
newpavlov merged commit 140876b into masterOct 14, 2024
@newpavlov
newpavlov deleted the nopanic branch October 14, 2024 17:16
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
…random#515)
The check is done by compiling `cdylib` which exposes `getrandom_uninit`
and checking that the result does not contain any strings with "panic".
For now CI only checks `linux_android_with_fallback`, `linux_android`,
`rdrand`, `wasi`, and `getentropy` backends. Other backend checks could
be added in future PRs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document and Test that getrandom() never panics.

1 participant

@newpavlov