Skip to content

Refactor util_libc - #765

Merged
newpavlov merged 7 commits into
masterfrom
refactor_util_libc
Dec 27, 2025
Merged

Refactor util_libc#765
newpavlov merged 7 commits into
masterfrom
refactor_util_libc

Conversation

@newpavlov

@newpavlovnewpavlov commented Dec 10, 2025•
edited
Loading

Copy link
Copy Markdown
Member

This PR refactors util_libc, sanitizer, and lazy modules. The modules are moved into the utils directory and "mounted" with #[path = ".."]. With this change all uses of #[path = ".."] point towards the utils directory.

newpavlov
newpavlov commented Dec 10, 2025
View reviewed changes
Comment threadsrc/utils/sys_fill_exact.rs
res if res > 0 => {
let len = usize::try_from(res).map_err(|_| Error::UNEXPECTED)?;
let (l, r) = buf.split_at_mut_checked(len).ok_or(Error::UNEXPECTED)?;
unsafe { sanitizer::unpoison(l) };

@newpavlovnewpavlovDec 10, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it applies unpoison to all users of sys_fill_exact. It's redundant in some cases (e.g. when we read from /dev/urandom), but AFAIK it has no negative consequences (outside of outlandish scenarios of misbehaving libc), while allowing to simplify the code a fair bit.

@newpavlovnewpavlov mentioned this pull request Dec 10, 2025
Closed
newpavlov
newpavlov commented Dec 10, 2025
View reviewed changes
Comment threadsrc/backends/getentropy.rs
#[path = "../util_libc.rs"]
mod util_libc;
#[path = "../utils/get_errno.rs"]
mod utils;

@newpavlovnewpavlovDec 10, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move imports of errno_location for 4 targets which use this backends here, but I don't think it's worth the trouble since all 4 targets use different names.

dhardy
dhardy approved these changes Dec 27, 2025
View reviewed changes

@dhardydhardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, esp. the changes to get_errno.

Comment threadsrc/utils/sys_fill_exact.rs
Comment threadsrc/backends/linux_raw.rs
@newpavlov
newpavlov merged commit 2fe4e79 into masterDec 27, 2025
100 of 101 checks passed
@newpavlov
newpavlov deleted the refactor_util_libc branch December 27, 2025 17:48
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
@newpavlov
Refactorutil_libc(rust-random#765)
43d1a33
This PR refactors `util_libc`, `sanitizer`, and `lazy` modules. The
modules are moved into the `utils` directory and "mounted" with
`#[path = ".."]`. With this change all uses of `#[path = ".."]` point
towards the `utils` directory.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhardydhardydhardy approved these changes
@josephlrjosephlrAwaiting requested review from josephlr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@newpavlov@dhardy