Skip to content

Fix Redox CI - #85

Merged
josephlr merged 2 commits into
rust-random:masterfrom
josephlr:redox
Aug 25, 2019
Merged

Fix Redox CI#85
josephlr merged 2 commits into
rust-random:masterfrom
josephlr:redox

Conversation

@josephlr

@josephlrjosephlr commented Aug 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#79

@newpavlov

newpavlov commented Aug 13, 2019

Copy link
Copy Markdown
Member

Hopefully rust-lang/rust#63521 will land soon and we will not have to use xbuild for Redox.

@newpavlov

newpavlov commented Aug 24, 2019

Copy link
Copy Markdown
Member

@josephlr
Can you revert to the old cargo build? The builder PR has landed, so we should get pre-built Redox std soon.

@josephlr

josephlr commented Aug 24, 2019

Copy link
Copy Markdown
MemberAuthor

@newpavlov will do. Looks like redox is now back to building in the latest nightly.
https://rust-lang.github.io/rustup-components-history/x86_64-unknown-redox.html

@newpavlov

newpavlov commented Aug 25, 2019

Copy link
Copy Markdown
Member

Argh, looks like libc is still broken on Redox...

@newpavlovnewpavlov mentioned this pull request Aug 25, 2019
Closed
@josephlr

josephlr commented Aug 25, 2019

Copy link
Copy Markdown
MemberAuthor

Argh, looks like libc is still broken on Redox...

I confirmed locally that 0.2.62 seems to fix things. So this can be merged once the CI passes.

@josephlr
josephlr merged commit 4db1b14 into rust-random:masterAug 25, 2019
@josephlr
josephlr deleted the redox branch August 25, 2019 02:23
@josephlr

josephlr commented Aug 25, 2019

Copy link
Copy Markdown
MemberAuthor

Whoops @newpavlov, I thought you had approved this, so I merged it. We should probably enable the feature that requires review before merging. Would that work for you?

@newpavlov

newpavlov commented Aug 25, 2019

Copy link
Copy Markdown
Member

Yeah, no problem. I am not sure if we need this setting, but either way, I think we will need @dhardy for that.

@dhardy

dhardy commented Aug 25, 2019

Copy link
Copy Markdown
Member

Done

takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
@josephlr
Fix Redox CI (rust-random#85)
13bb917
* Fix Redox CI
* Bump libc version to fix Redox
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redox support

3 participants

@josephlr@newpavlov@dhardy