Add VxWorks support by newpavlov · Pull Request #86 · rust-random/getrandom

newpavlov · 2019-08-14T15:00:40Z

I couldn't find a proper documentation for VxWorks, so I've mostly just copied code from std.

This PR will not work until rust-lang/libc#1473 lands.

BaoshanPang · 2019-08-14T16:46:21Z

Thanks for working this, I am actually looking for the way to port rand for vxWorks with latest version, the layout of version 0.7.0 is quiet different than 0.6.1 which we have ported for.

I don't see any problem with the code, it is good to me.

Can you teach me how to test it for vxWorks? I am seeing rand 0.6.1(and 0.6.5) is used when runing rust libstd unit test, but I can't figure out where/how rand 0.7.0 is used.

Thanks,
Baoshan

newpavlov · 2019-08-14T16:56:32Z

If I understood you correctly, then you don't have to do anything. Assuming this PR is correct, after publishing the next version of getrandom with it, rand v0.7 should start working on VxWorks automatically.

libstd only recently started using rand v0.7, I think after this PR: rust-lang/rust#61393.

BaoshanPang · 2019-08-14T17:02:44Z

libstd only recently started using rand v0.7, I think after this PR: rust-lang/rust#61393.
I see. Thanks.

newpavlov · 2019-08-14T20:57:15Z

@n-salim
Also do we have to provide any linking arguments to Cargo? See build.rs. Note that in future getrandom may be used as a dependency of std.

n-salim · 2019-08-14T21:17:08Z

Also do we have to provide any linking arguments to Cargo?
Good question. Luckily randBytes is part of VxWorks libc.a, which we already always link against.

newpavlov · 2019-08-14T22:09:37Z

Luckily randBytes is part of VxWorks libc.a, which we already always link against.

How about adding randBytes to the libc crate then? It would allow us to simplify code in getrandom a bit. Also please take look at rust-lang/libc#1469.

BaoshanPang · 2019-08-14T22:18:06Z

How about adding randBytes to the libc crate then?

I will do it as part of libc#1469.

BaoshanPang · 2019-08-17T02:55:31Z

If I understood you correctly, then you don't have to do anything. Assuming this PR is correct, after publishing the next version of getrandom with it, rand v0.7 should start working on VxWorks automatically.
libstd only recently started using rand v0.7, I think after this PR: rust-lang/rust#61393.

I just built the latest rust code , although there are both rand 0.7 and rand 0.6.1 listed in Cargo.lock, but the rand used is still 0.6.1 when building libstd unit test:

$ ./x.py test -i --stage 1 src/libstd
...
Compiling rand v0.6.1

Some update for vxWorks This is to address issues: #1469 and rust-random/getrandom#86 (comment) What have been changed in this PR: 1. adding randBytes(), randABytes(), randUBytes(), randSecure() and taskDelay() 2. change armv7-wrs-vxworks to armv7-wrs-vxworks-eabihf 3. code cleanup

josephlr

The basic gist of this looks good, just a few things to prevent some build issues.

I'm not sure if you need to rebase onto latest master (I guess it couldn't hurt).

josephlr · 2019-09-18T03:20:08Z

+static RNG_INIT: AtomicBool = AtomicBool::new(false);
+
+pub fn getrandom_inner(dest: &mut [u8]) -> Result<(), Error> {
+ while !RNG_INIT.load(Relaxed) {


We should use LazyBool here, something like:
fnrng_init() -> bool{loop{let ret = unsafe{ libc::randSecure()}if ret != 0{return ret > 0;}unsafe{ libc::usleep(10)};}}
pubfn getrandom_inner(dest:&mut[u8]) -> Result<(),Error>{staticRNG_INIT:LazyBool = LazyBool::new();if !RNG_INIT.unsync_init(rng_init){returnErr(RAND_SECURE_FATAL);}// Prevent overflow of i32 ...
You could also use a lambda, if you think it would look better.

@BaoshanPang @n-salim
Is it possible for the system to recover after randSecure failure or can we assume that once it has failed it will always fail?

Yes, the system can recover after randSecure failure. This is the randSecure's function desciption:
randSecure - determine if state is secure
This routine determines if state is secure and returns status.
When the system boots, the SW random number lib contains no entropy. Once
enough entropy has been collected in order to make the random numbers
cryptographically secure, the state is considered to be secure.
It will make a system call to a kernel side handler.
RETURNS: 1 if the state is secure, 0 if the state is not secure, ERROR if
the random number generator module is not initialized.
ERRNOS: N/A

"ERROR if the random number generator module is not initialized."
If I'm understanding this right, the RNG module might not be initialized, but it could become initialized later?
If that's the case, the current code looks good to me.

josephlr

Nice job @newpavlov for fixing this.

josephlr · 2019-10-23T07:25:25Z

+static RNG_INIT: AtomicBool = AtomicBool::new(false);
+
+pub fn getrandom_inner(dest: &mut [u8]) -> Result<(), Error> {
+ while !RNG_INIT.load(Relaxed) {


"ERROR if the random number generator module is not initialized."
If I'm understanding this right, the RNG module might not be initialized, but it could become initialized later?
If that's the case, the current code looks good to me.

newpavlov added 2 commits August 14, 2019 17:58

add vxworks support
bdf7c94

fix
a2a7b11

newpavlov mentioned this pull request Aug 14, 2019
Use getrandom crate rust-lang/rust#62082
Closed

fix2
fd002ec

BaoshanPang approved these changes Aug 14, 2019
View reviewed changes

n-salim reviewed Aug 14, 2019
View reviewed changes

Comment threadsrc/vxworks.rs Outdated

n-salim reviewed Aug 14, 2019
View reviewed changes

Comment threadsrc/vxworks.rs Outdated

This was referenced Aug 14, 2019
code cleanup and adding randBytes() Wind-River/libc#1
Merged
Some update for vxWorks rust-lang/libc#1473
Merged

newpavlov added 4 commits August 18, 2019 03:07

use libc
38a0254

fix
625d97d

fix2
d34f279

add RAND_SECURE_FATAL constant
234cf6c

newpavlov added 2 commits August 26, 2019 15:41

Merge branch 'master' into vxworks
b0b4ad4

simplify libc cfg
7113c54

josephlr mentioned this pull request Sep 18, 2019
Fix building issue #105
Closed

josephlr reviewed Sep 18, 2019
View reviewed changes

Comment threadCargo.toml Outdated

newpavlov added 2 commits October 15, 2019 18:21

libc update
78a9054

fix cfg
ce5c773

newpavlov added 2 commits October 22, 2019 16:52

revert cfg_if formatting
168806b

move RNG_INIT
2f13c46

newpavlov requested a review from dhardy October 22, 2019 15:31

josephlr approved these changes Oct 23, 2019
View reviewed changes

update RAND_SECURE_FATAL description
eb79bb7

newpavlov merged commit 9a385f1 into masterOct 23, 2019

newpavlov deleted the vxworks branch October 28, 2019 15:51

takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
Add VxWorks support (rust-random#86)
f5fff98

Uh oh!

Conversation

newpavlov commented Aug 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BaoshanPang commented Aug 14, 2019

Uh oh!

newpavlov commented Aug 14, 2019

Uh oh!

BaoshanPang commented Aug 14, 2019

Uh oh!

Uh oh!

Uh oh!

newpavlov commented Aug 14, 2019

Uh oh!

n-salim commented Aug 14, 2019

Uh oh!

newpavlov commented Aug 14, 2019

Uh oh!

BaoshanPang commented Aug 14, 2019

Uh oh!

BaoshanPang commented Aug 17, 2019

Uh oh!

josephlr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josephlrSep 18, 2019

Choose a reason for hiding this comment

Uh oh!

newpavlovOct 22, 2019

Choose a reason for hiding this comment

Uh oh!

BaoshanPangOct 22, 2019

Choose a reason for hiding this comment

Uh oh!

josephlrOct 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josephlr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

josephlrOct 23, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

newpavlov commented Aug 14, 2019•
edited
Loading