Skip to content

Update GitHub Actions - #1263

Merged
dhardy merged 3 commits into
masterfrom
work5
Nov 10, 2022
Merged

Update GitHub Actions#1263
dhardy merged 3 commits into
masterfrom
work5

Conversation

@dhardy

@dhardydhardy commented Nov 10, 2022

Copy link
Copy Markdown
Member

... plus a couple of minor things

@newpavlov

newpavlov commented Nov 10, 2022

Copy link
Copy Markdown
Member

I wouldn't say that bumping MSRV to 1.51 is a "minor thing".

@dhardy

dhardy commented Nov 10, 2022

Copy link
Copy Markdown
MemberAuthor

The actual bump was already merged: #1246.

newpavlov
newpavlov approved these changes Nov 10, 2022
View reviewed changes

@newpavlovnewpavlov left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think 1.51 could be a bit too steep for a crate like rand. With bump to 1.38 we could shift responsibility to crossbeam, it's much less impactful, and it's easier to pin one crate to preserve the old MSRV, than a number of affected rand crates. Be prepared to the same reaction as we've seen for once_cell, if not worse.

But I guess, it's too late to raise such concerns...

@dhardy

dhardy commented Nov 10, 2022

Copy link
Copy Markdown
MemberAuthor

The next Rand release will be a breaking release. once_cell had a major bump in a non-breaking release.

Given that, and that 1.51 is likely to be two years old by the time Rand 0.9 releases (or more, we're not exactly making rapid progress on it), I don't think this is an issue.

@dhardy
dhardy merged commit 9720f11 into masterNov 10, 2022
@newpavlov

newpavlov commented Nov 10, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Ah, if MSRV bump will be done as part of v0.9, then I have no objections. It could be even worth to bump to 1.56 for edition update.

@dhardy

dhardy commented Nov 10, 2022

Copy link
Copy Markdown
MemberAuthor

👍

The gh-pages deployment needs fixing :-(

benjamin-lieser pushed a commit to benjamin-lieser/rand that referenced this pull request Feb 5, 2025
@dhardy
Update GitHub Actions (rust-random#1263)
3a2d580
* examples/rayon-monte-carlo.rs: remove execute bit of file metadata
* Document in README that MSRV is 1.51.0
This was changed in rust-random#1246
* Update GitHub Actions
@ghost-of-high-heartghost-of-high-heartBot mentioned this pull request Apr 5, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newpavlovnewpavlovnewpavlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhardy@newpavlov