Move OsRng down to rand

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}

[dhardy]

• Added a CHANGELOG.md entry

Summary

Moves OsRng from rand_core to rand.

Removes fns SeedableRng::from_os_rng and try_from_os_rng.

Motivation

This removes the dependency on getrandom, making rand_core dependency-free (unless serde is enabled) and allowing an easier path to stabilisation of rand_core. See rust-random/rand_core#13.

Details

Removed features std and os_rng from rand_core.

[dhardy]

This is certainly less ergonomic than before, but affected us very little.

Unknown: how much this impacts other users.

[vks]

This reverts a change we did a long time ago. Do you remember why we moved it from rand_os to rand_core in the first place?

[dhardy]

SeedableRng::from_os_rng requires OsRng. We want to keep SeedableRng in rand_core, so essentially we must choose between:

1. Do not offer a from_os_rng method (this PR). This works fine for us but there are clearly some users (GH search).
2. Status quo: rand_core depends on getrandom for from_os_rng.
3. Add an extension trait SeedableRngExt: SeedableRng in rand and implement from_os_rng there. We could also add from_thread_rng in that case.

[zArubaru]

Now that ChaCha8Rng::from_os_rng() is deprecated and removed, maybe someone else is searching for a way to conditionally seed rng. Probably obvious for some, took me a while 😅

use rand::RngExt;use rand_chacha::rand_core::SeedableRng;use rand_chacha::ChaCha8Rng;let maybe_seed:Option<u64> = None;letmut rng = ifletSome(seed) = maybe_seed {ChaCha8Rng::seed_from_u64(seed)}else{ChaCha8Rng::from_rng(&mut rand::rng())};if rng.random_bool(0.1){println("Maybe this will print, maybe it won't!");}