Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other changes:
Isaac64Rng::next_u32is a breaking change, because it no longer throws away half the results.{IsaacRng, Isaac64Rng}::new_unseededis no longer available. Use{IsaacRng, Isaac64Rng}::new_from_u64(0)as replacement.Copy.Does it make sense to say something about
impls? Or not advertise it too widely, because it may move torand_core?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of that's merged yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was your goal to include them in this release after #205 (comment). Because they contain (small) breaking changes, they can't be part of 0.4.* if we follow semver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments. Didn't think about lack of
Copybeing a breaking change, but you're right, it is (maybe we should add a deprecated impl?).new_unseededwe can potentially add back as adeprecatedwrapper fn. So perhaps those changes can't land in 0.4 after all, or at least not all of them :/BTW it should have been clear from this PR what was/wasn't in the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I finally get the scheme you have in mind 😄