Uh oh!
There was an error while loading. Please reload this page.
Prepare new releases, from_rng Endianness and inlining - #815
Merged
Conversation
vks
reviewed
Jun 5, 2019
Uh oh!
There was an error while loading. Please reload this page.
vks
reviewed
Jun 5, 2019
Uh oh!
There was an error while loading. Please reload this page.
We now have value stability, so should test this
Also patch two READMEs
dhardy
commented
Jun 5, 2019
MemberAuthor
Rebased with your suggestions |
vks
approved these changes
Jun 5, 2019
vks
left a comment
Contributor
There was a problem hiding this comment.
Looks good! The tests fail apparently because of the rand requirement of rand_distr.
dhardy
commented
Jun 5, 2019
MemberAuthor
Hopefully that should fix the tests. |
dhardy
commented
Jun 6, 2019
MemberAuthor
Turns out #572 isn't just documentation: the custom implementation for XorShiftRng needed fixing. Curiously the custom implementations for the ISAAC RNGs already have fixed Endianness. |
dhardy
commented
Jun 6, 2019
MemberAuthor
Use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the 0.7 pre-release and releases of many other crates (the only one without changes is PCG, though some are just doc).
Important: this is missing
rand_distrwhich I asked @vks to look at.Also closes#572, most of which was already implemented (probably as part of #800).