Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 30, 2019. It is now read-only.
[WIP] Update futures-preview to 0.3.0-alpha.16 - #26
Merged
Conversation
taiki-e
marked this pull request as ready for review
May 9, 2019 02:50
taiki-eforce-pushed
the
await
branch
2 times, most recently
from
May 9, 2019 03:04
23b6040 to
970cc75Comparetaiki-e
commented
May 11, 2019
ContributorAuthor
futures 0.3.0-alpha.16 was released, so I added a commit and updated this PR. |
taiki-e
commented
May 11, 2019
ContributorAuthor
This PR is blocked on withoutboats/romio#87 and withoutboats/juliex#18. |
yoshuawuyts
approved these changes
May 12, 2019
yoshuawuyts
left a comment
Collaborator
There was a problem hiding this comment.
This looks great; thanks heaps!
yoshuawuyts
commented
May 12, 2019
Collaborator
Oh oops, meant to hit merge on the Romio PR. Going to merge those first, and loop around to fixing this. Running the release train today! |
yoshuawuyts
commented
May 12, 2019
Collaborator
Yay, fixed it and ran a full deploy for all crates! Thanks so much @taiki-e!! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
awaitsyntax was implemented in rust-lang/rust#60586, and nightly-2019-05-09 has been released with the changes. Also,await!macro will be removed in the future.Then, futures 0.3.0-alpha.16 was released.
Refs: migration tool
Motivation and Context
Types of changes
With this change, the minimum required version will go up to nightly-2019-05-09.