Uh oh!
There was an error while loading. Please reload this page.
chore(deps): unblock esbuild 0.28.1 via esbuild-loader 4.5.0 - #162
Merged
Conversation
Alert #62 needs esbuild 0.28.1, but esbuild-loader 4.4.x declares "^0.27.1", which caps below 0.28.0 (caret on a 0.x range). yarn up -R esbuild was therefore a no-op. esbuild-loader 4.5.0 moved to "^0.28.1", and @backstage/cli-module-build already declares "esbuild-loader": "^4.0.0", which accepts it: esbuild-loader 4.4.x -> 4.5.0 esbuild 0.27.4 -> 0.28.1 Most of the diff is esbuild's 26 platform-specific binary packages (@esbuild/darwin-arm64, linux-x64, …) moving in lockstep; only two logical entries change. esbuild-loader is the bundler's TS/JS transform, so this was verified through both build paths: yarn build for the plugins and the frontend app build that CI does not run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Dependabot alert #62 (low,
esbuild— dev-scoped).Why a direct bump couldn't fix it
The advisory covers
>= 0.27.3, < 0.28.1and needs 0.28.1. Because esbuild is on a0.xline,^0.27.1means>=0.27.1 <0.28.0— soyarn up -R esbuildwas a no-op, the same major-boundary wall seen in #153 and #161.What this does
esbuild-loader 4.5.0 moved to
esbuild: ^0.28.1, and@backstage/cli-module-buildalready declaresesbuild-loader: ^4.0.0, which accepts it:esbuild-loaderesbuildLockfile-only, no manifest touched. The diff looks large (117 insertions / 134 deletions) but only two logical entries change — the bulk is esbuild's 26 platform-specific binary packages (
@esbuild/darwin-arm64,@esbuild/linux-x64, …) moving in lockstep, which is how esbuild ships.Verification
esbuild-loaderis the bundler's TS/JS transform, so both build paths were exercised:yarn install --immutableyarn typecheckyarn build(all plugins)yarn workspace app buildyarn lintyarn testyarn format:checkThe app build matters most here: CI's
yarn buildis scoped to--include '@rwdocs/*'and never bundles the frontend, which is where esbuild-loader does the bulk of its work.Context
This is the last readily fixable alert in the backlog. The nine that remain are all blocked on upstream movement rather than on anything actionable here:
@backstage/integrationandbackend-defaultspin@octokit/rest: ^19.0.3at their current latestv7, unaffectedrefractor@3; needs Backstage to move toreact-syntax-highlighter16latest, with no patched version published🤖 Generated with Claude Code