Skip to content

fix: resolve 'changed'/'all' extensions in downstream publish jobs#165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peternhale merged 2 commits into from
Jul 29, 2026
Merged

fix: resolve 'changed'/'all' extensions in downstream publish jobs #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37e2ef
fix: resolve 'changed'/'all' extensions in downstream publish jobs
peternhale Jul 29, 2026
3c316d6
fix: resolve selected-extensions in publish-skipped-notice
peternhale Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/vscode-publish-extensions.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -549,7 +549,7 @@ jobs:
extensions-root: ${{ inputs.extensions-root || 'packages' }}

determine-publish-matrix:
needs: [calculate-artifact-name]
needs: [determine-changes, calculate-artifact-name]
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.matrix.outputs.matrix }}
Expand All@@ -569,7 +569,7 @@ jobs:
id: matrix
env:
REGISTRIES: ${{ inputs.registries }}
SELECTED_EXTENSIONS: ${{ inputs.extensions }}
SELECTED_EXTENSIONS: ${{ needs.determine-changes.outputs.selected-extensions }}
IS_NIGHTLY: 'true'
EXTENSIONS_ROOT: ${{ inputs.extensions-root || 'packages' }}
run: |
Expand DownExpand Up@@ -636,6 +636,7 @@ jobs:
name: Publish Skipped Notice
needs:
[
determine-changes,
bump-versions,
package,
calculate-artifact-name,
Expand All@@ -648,7 +649,7 @@ jobs:
run: |
echo "ℹ️ Marketplace publishing skipped for this build type"
echo " Reason: Nightly builds only create GitHub releases, not marketplace publishes"
echo " Extensions would be published: ${{ inputs.extensions }}"
echo " Extensions would be published: ${{ needs.determine-changes.outputs.selected-extensions }}"
echo " Registries configured: ${{ inputs.registries }}"

publish:
Expand DownExpand Up@@ -785,9 +786,9 @@ jobs:

create-github-releases:
name: Create GitHub Releases
needs: [package, calculate-artifact-name]
needs: [determine-changes, package, calculate-artifact-name]
runs-on: ubuntu-latest
if: needs.package.result == 'success' && inputs.extensions != '' && github.event_name != 'pull_request'
if: needs.package.result == 'success' && needs.determine-changes.outputs.selected-extensions != '' && github.event_name != 'pull_request'
steps:
- name: Checkout
uses: actions/checkout@v6
Expand All@@ -813,7 +814,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.IDEE_GH_TOKEN }}
GITHUB_REPOSITORY: ${{ github.repository }}
SELECTED_EXTENSIONS: ${{ inputs.extensions }}
SELECTED_EXTENSIONS: ${{ needs.determine-changes.outputs.selected-extensions }}
IS_NIGHTLY: 'true'
PRE_RELEASE: 'true'
VERSION_BUMP: ${{ inputs.version-bump }}
Expand DownExpand Up@@ -972,7 +973,7 @@ jobs:
slack-notify:
name: Slack Notification
needs:
[bump-versions, package, publish, publish-skipped-notice]
[determine-changes, bump-versions, package, publish, publish-skipped-notice]
runs-on: ubuntu-latest
if: always() && (needs.publish.result == 'success' || needs.publish.result == 'skipped')
steps:
Expand All@@ -987,7 +988,7 @@ jobs:
EXTENSIONS_ROOT: ${{ inputs.extensions-root || 'packages' }}
run: |
# Get selected extensions and their details
SELECTED_EXTENSIONS="${{ inputs.extensions }}"
SELECTED_EXTENSIONS="${{ needs.determine-changes.outputs.selected-extensions }}"
VERSION_BUMP="${{ inputs.version-bump }}"
PRE_RELEASE="true"

Expand All@@ -1003,7 +1004,7 @@ jobs:
PACKAGE_NAME=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').name")
PACKAGE_VERSION=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').version")
DISPLAY_NAME=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').displayName || require('./$EXTENSIONS_ROOT/$ext/package.json').name")

# Add to arrays
if [ -z "$EXTENSION_NAMES" ]; then
EXTENSION_NAMES="$PACKAGE_NAME"
Expand DownExpand Up@@ -1098,7 +1099,7 @@ jobs:
slack-notify-failure:
name: Slack Failure Notification
needs:
[bump-versions, package, publish, publish-skipped-notice]
[determine-changes, bump-versions, package, publish, publish-skipped-notice]
runs-on: ubuntu-latest
if: always() && (needs.publish.result == 'failure' || needs.bump-versions.result == 'failure' || needs.package.result == 'failure')
steps:
Expand All@@ -1113,7 +1114,7 @@ jobs:
EXTENSIONS_ROOT: ${{ inputs.extensions-root || 'packages' }}
run: |
# Get selected extensions and their details
SELECTED_EXTENSIONS="${{ inputs.extensions }}"
SELECTED_EXTENSIONS="${{ needs.determine-changes.outputs.selected-extensions }}"
VERSION_BUMP="${{ inputs.version-bump }}"
PRE_RELEASE="true"

Expand All@@ -1129,7 +1130,7 @@ jobs:
PACKAGE_NAME=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').name")
PACKAGE_VERSION=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').version")
DISPLAY_NAME=$(node -p "require('./$EXTENSIONS_ROOT/$ext/package.json').displayName || require('./$EXTENSIONS_ROOT/$ext/package.json').name")

# Add to arrays
if [ -z "$EXTENSION_NAMES" ]; then
EXTENSION_NAMES="$PACKAGE_NAME"
Expand Down