config-vm: Recycle the hook-process schema - #2
Closed
wking wants to merge 2 commits into
Closed
Conversation
wkingforce-pushed
the
use-hook-structure-for-hypervisor
branch
from
March 21, 2018 16:22
85e26b0 to
218660dCompareSo we'll be able to link to it without linking the rest of the 'hooks' structure. Signed-off-by: W. Trevor King <wking@tremily.us>
We already have two ways to specify a process to launch (for the container process and for hooks). This commit recycles the hook-process schema for launching the hypervisor. I prefer using the more-fundamental container process schema, but Michael felt it had too many properties that wouldn't apply to the hypervisor-launching case [1]. [1]: opencontainers#949 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wkingforce-pushed
the
use-hook-structure-for-hypervisor
branch
from
April 2, 2018 03:59
218660d to
9da1f6eComparewking
commented
Apr 2, 2018
CollaboratorAuthor
With opencontainers#949 merged, I'm closing this PR and opening one against master with the same content: opencontainers#962. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have two ways to specify a process to launch (for the container process and for hooks). This commit recycles the hook-process schema for launcing the hypervisor. I prefer using the more-fundamental container process schema, but @crosbymichael felt it had too many properties that wouldn't apply to the hypervisor-launching case.