Uh oh!
There was an error while loading. Please reload this page.
test: isolate Kiro maintenance from host configuration - #27
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed\n\n- Isolate packaged doctor/unregister tests from host Kiro and workspace configuration by setting temporary HOME, KIRO_HOME, and PWD.\n- Keep the Kiro doctor test focused on its current read-only Skill probe contract; unregister requires an owned MCP credential/config transaction and is covered by the dedicated Kiro unregister tests.\n\n## Evidence\n\n- Before: full suite had 2 failures caused by
/Users/.../.kiro/settings/mcp.jsonleaking into tests.\n- After:npm run lint;npm test= 149 pass, 1 skip, 0 fail;npm run audit:packagepassed.\n\nNo production code or credentials changed.