Uh oh!
There was an error while loading. Please reload this page.
Some suggested tweaks to Part 2 - #30
Open
treyhunner wants to merge 6 commits into
Open
Conversation
treyhunner
commented
Sep 15, 2014
MemberAuthor
By the way, I really like the "neato trick" section. Do you think we should give that a name (unpacking?) or just show it off and leave it at that? |
pydanny
commented
Sep 15, 2014
Contributor
We can call it unpacking. |
treyhunner
commented
Sep 15, 2014
MemberAuthor
I added a couple more commits. I'm done with my suggestions for this section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pydanny Thoughts on each of these changes?
I made 4 separate commits and I can remove/undo/tweak any of them that you'd like.