Fix non-deterministic stdout and stderr interleaving - #38
Open
finn-episub wants to merge 2 commits into
Open
Conversation
Covers the split-stream stderr diff path with a real fixture (a NOTICE from DROP TABLE IF EXISTS) instead of only exercising it manually, and adds a test confirming a stderr-only regression is caught even when stdout is unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When not outputting to a tty postgres uses block buffering for stdout but stderr is unbuffered. This creates a race condition where merging stdout and stderr can produce different ordering when the streams are merged. This PR splits them into two separate outputs and compares then separately.
Another option that was considered was allocating a pty rather than a pipe but that would have been more complicated and required some windows specific code and testing.
Checklist