Skip to content

Make logging customizable - #1

Merged
jvican merged 4 commits into
scalacenter:masterfrom
mzarnowski:make-logging-customizable
Jul 31, 2019
Merged

Make logging customizable#1
jvican merged 4 commits into
scalacenter:masterfrom
mzarnowski:make-logging-customizable

Conversation

@mzarnowski

@mzarnowskimzarnowski commented Jul 23, 2019•
edited
Loading

Copy link
Copy Markdown

Currently all of the loggers are static. This makes them non-static and allows the users to customize them on creation.

@mzarnowski
mzarnowski requested a review from jvicanJuly 23, 2019 09:50
jvican
jvican approved these changes Jul 31, 2019
View reviewed changes

@jvicanjvican left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 This is great, thank you! It's really a pity that Java libraries use static loggers.

@jvican
jvican merged commit 244576a into scalacenter:masterJul 31, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jvicanjvicanjvican approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mzarnowski@jvican