Skip to content

Add FileWidget.FILE_AND_DIRECTORY_STYLE - #480

Merged
ctrueden merged 2 commits into
scijava:masterfrom
tischi:file-widget-both
Jul 10, 2024
Merged

Add FileWidget.FILE_AND_DIRECTORY_STYLE#480
ctrueden merged 2 commits into
scijava:masterfrom
tischi:file-widget-both

Conversation

@tischi

Copy link
Copy Markdown
Contributor

No description provided.

@NicoKiaru

Copy link
Copy Markdown
Contributor

Quick note to mention that the documentation in imagej.net needs to be updated once the PR is merged:

https://imagej.net/scripting/parameters

@NicoKiaru

Copy link
Copy Markdown
Contributor

Also, instead of "both", maybe something like "file_or_directory", since "both" isn't very clear out of context.
Last, how does this behave with a file array parameter ?

@tischi

Copy link
Copy Markdown
ContributorAuthor

I am using "both" because that's what is already used for the FileListWidget.

@NicoKiaru

Copy link
Copy Markdown
Contributor

Ah great! Then the FileArray widget is already working. Good to know!

@imagejanimagejan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tischi!

Looks good to me, I just added suggestion to remove one of the TODO comments.

Comment threadsrc/main/java/org/scijava/ui/UserInterface.java Outdated
@tischi

Copy link
Copy Markdown
ContributorAuthor

Thanks @imagejan, these TODO were not added by me, but what you did LGTM.

Do I need to accept/commit your changes or can you do it?

@ctrueden
ctrueden merged commit 9a9fb72 into scijava:masterJul 10, 2024
@ctrueden

Copy link
Copy Markdown
Member

Thanks, all!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tischi@NicoKiaru@ctrueden@imagejan