Skip to content

Add Codecov CI / comment report in each PR - #89

Merged
sbillinge merged 3 commits into
scikit-package:mainfrom
bobleesj:patch-10
Nov 5, 2024
Merged

Add Codecov CI / comment report in each PR#89
sbillinge merged 3 commits into
scikit-package:mainfrom
bobleesj:patch-10

Conversation

@bobleesj

Copy link
Copy Markdown
Contributor

CI passes with a comment when coverage has gone up or remains the same:

Screenshot 2024-11-01 at 7 20 13 PM

CI fails when coverage decreases:

Screenshot 2024-11-01 at 8 19 11 PM

codecov

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading to the branch within Codecov.io other than main to generate the PR comment. This approach ensures that the user-facing main branch coverage remains unaffected during a PR:

I have tested using a dummy package:

branch:

https://app.codecov.io/gh/bobleesj-test-org/bobleesj.release/commits/test-codecov

main:

https://app.codecov.io/gh/bobleesj-test-org/bobleesj.release/commits/main

@bobleesjbobleesj left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge ready for review - needs to be merged to v0 after.

@sbillinge
sbillinge merged commit 3800d60 into scikit-package:mainNov 5, 2024
@bobleesj
bobleesj deleted the patch-10 branch November 5, 2024 03:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bobleesj@sbillinge