Conversation
Squashed for a clean rebase onto main after v0.5.0 landed, and reverted the changelog.d/ fragment system in favor of a direct CHANGELOG.md edit (dropped per team discussion — more process than this repo's PR concurrency warrants). Functional content is unchanged from the original review. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BK3fzED9ksTWsvoPfsEwpS
fb9cd7e to
ebbd49f
Compare
|
This reverts the merged v0.5.0 CHANGELOG entry.
The identical clobber is in #36, so fixing one doesn't fix the other — whichever merges second re-applies it. #32 and #33 branch from the same commit and leave Is the CHANGELOG restructure intentional? Nothing in the description, the commit message, or #29 mentions it. |
Addresses part of #29 (tracking issue — see there for the full checklist; a companion PR handles the remaining structured-output/command-correctness items).
Chart rendering (
internal/output/chart.go)Summary:always shows, including a genuine zero, matching the other three stats.internal/output/chart_test.gocovers all five with 13 cases, including a 600-point series with one spike that survives downsampling to 60 points.Docs & help text
os.UserConfigDirreturns~/Library/Application Supporton macOS, not~/.config).scout auth statusnow prints the config path in use, and the README points at it.--helplistsanomalies,insights,usage,billing;--fromhelp includes2w.Example:blocks tojobs metrics,traces list,metrics get,endpoints metrics.scout X list" instead, so the examples don't rot.CI
.github/workflows/ci.ymlnow runsgofmt -landgo vet ./...alongside the existing test/lint jobs. Fixed the one pre-existing unformatted file (internal/output/progress.go) so the new check is unconditional.Remaining polish
scout billing's usage bars now show one block for any nonzero usage (previously rounded to an empty bar below 2.5%).--jsonoutput is uncapped.scout apps shownow reportslast_reported_at, falling back to the list payload (the single-app API response omits it).output.Truncate, so it can't split a multibyte character.scout metrics get/scout endpoints metricsnow validate--typeclient-side with the valid list, instead of round-tripping to the server for a 422 (matchingjobs metrics's existing behavior).scout setup <name>now matches case-insensitively, with a clearer error pointing atscout setupfor the valid list.Note on
cmd/setup.goThis branch merges in #32 (issue #27's docs-URL fix) so the case-insensitivity fix here composes with the corrected per-framework URLs rather than conflicting with it later —
scout setup RAILSnow both matches case-insensitively and resolves to the real docs page.Test plan
gofmt -l .(clean, including the previously-unformatted file)go vet ./...,go build,go test -race ./...,golangci-lint run ./...— all cleanauth status(config path),billing(usage bars),setup RAILS/setup notarealframework,metrics get --type bogus, chart titles with decoded names🤖 Generated with Claude Code
https://claude.ai/code/session_01BK3fzED9ksTWsvoPfsEwpS