Uh oh!
There was an error while loading. Please reload this page.
Add UI for setting stream resolution (in width) - #252
Open
Luhav wants to merge 1 commit into
Open
Conversation
| constdefaults: Settings={ | ||
| displayMode: VideoDisplayMode.FitToWindow, | ||
| framerate: 30, | ||
| width: 1920, |
Member
There was a problem hiding this comment.
The default should be unlimited, meaning no width set on the getDisplayMedia query. Screego is optimized for code sharing and having the highest resolution should be the default.
There should also be a way to limit by height. So there should be two settings "Max Stream Width (px)" and "Max Stream Height (px)" where empty means no limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #228, adds a setting field for stream resolution defined by the width.
It's defined by width (as opposed to height) so that two monitors of the same resolution class but of different aspect ratios (such as 16:9 1920x1080 & 16:10 1920x1200) are both treated the same way (as opposed to the 16:10 stream being scaled down to some weird non-integer resolution). The default is 1920, to make 1080p, but of course can be set to any arbitrary number.