Uh oh!
There was an error while loading. Please reload this page.
Upgrade astro version v4 - #220
Merged
Merged
Conversation
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zzq0826force-pushed
the
upgrade-astro-version-v4
branch
from
March 22, 2024 12:35
588ba1a to
60839b0Comparezzq0826
marked this pull request as ready for review
March 22, 2024 12:48
dghelm
commented
Mar 27, 2024
Contributor
Images are no longer allowing for "zoom" as in this page: https://deploy-preview-220.docs.scroll.xyz/en/technology/ |
zzq0826
commented
Mar 28, 2024
MemberAuthor
Are you referring to this feature? It works for me, it might require the page to be fully loaded?
|
dghelm
commented
Apr 15, 2024
Contributor
Two bugs fixed:
Also, moved ViewTransition invocation logic from Header (UI element) to HeadCommon (lives in For follow-up: Can we move to a shared tag between different pages? Would this let us use a transition with expected behavior? |
dghelm
commented
Apr 15, 2024
Contributor
For follow-up (low priority): Can we maintain page transition across translation shifts when language selector is used? |
dghelm
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.