Skip to content

Feature/add chainlink - #322

Merged
ChuhanJin merged 3 commits into
scroll-tech:developfrom
melchermaxwell:feature/add-Chainlink
Aug 29, 2024
Merged

Feature/add chainlink#322
ChuhanJin merged 3 commits into
scroll-tech:developfrom
melchermaxwell:feature/add-Chainlink

Conversation

@melchermaxwell

@melchermaxwellmelchermaxwell commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Closing issues

Description

Add Chainlink to the Scroll Developer tools

Changes

-added chainlink.mdx with relevant info

@netlify

netlifyBot commented Aug 23, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for scroll-documentation ready!

NameLink
🔨 Latest commit2625b1a
🔍 Latest deploy loghttps://app.netlify.com/sites/scroll-documentation/deploys/66cc820d94b53900081cced4
😎 Deploy Previewhttps://deploy-preview-322.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dghelm

dghelm commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Glad to see Chainlink added here! Wondering if we could provide useful information for Scroll devs, since only a subset of Chainlinks docs are relevant to developers.

Could we provide LINK token address, Sequencer Uptime Feed address (or direct link) along with a pricefeed link for Scroll?

thedriftofwords
thedriftofwords suggested changes Aug 23, 2024
View reviewed changes
Comment threadsrc/content/tools/en/chainlink.mdx Outdated
@thedriftofwords

thedriftofwords commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

@dghelm thanks for the suggestions. I've added links to the sections of the Chainlink docs that contain the info you asked for. We prefer to use docs links instead of including the addresses directly, so that you have the link to the latest info in case anything changes in the future.

@melchermaxwell@thedriftofwords
Update src/content/tools/en/chainlink.mdx
2625b1a
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
emilyJLin95
emilyJLin95 approved these changes Aug 28, 2024
View reviewed changes

@emilyJLin95emilyJLin95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuhanJin
ChuhanJin self-requested a review August 29, 2024 04:03
@ChuhanJin
ChuhanJin merged commit e1c6f7e into scroll-tech:developAug 29, 2024
ChuhanJin added a commit that referenced this pull request Aug 29, 2024
@ChuhanJin
Merge pull request#326from scroll-tech/chuhan_prod
3eb33f2
Merge #322(Feature/add chainlink) from develop to prod
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@thedriftofwordsthedriftofwordsthedriftofwords approved these changes
@emilyJLin95emilyJLin95emilyJLin95 approved these changes
@ChuhanJinChuhanJinChuhanJin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@melchermaxwell@dghelm@thedriftofwords@emilyJLin95@ChuhanJin