Skip to content

fix(sender): panic when resubmitting failure - #1133

Merged
0xmountaintop merged 3 commits into
developfrom
fix-sender-panic-when-resubmitting-failed
Feb 19, 2024
Merged

fix(sender): panic when resubmitting failure#1133
0xmountaintop merged 3 commits into
developfrom
fix-sender-panic-when-resubmitting-failed

Conversation

@colinlyguo

@colinlyguocolinlyguo commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

Purpose or design rationale of this PR

Fix a bug that would cause panic.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguocolinlyguo added bug Something isn't working bump-version Bump the version tag for deployment labels Feb 18, 2024
@codecov

codecovBot commented Feb 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6030927) 57.07% compared to head (d4cc0ea) 57.07%.

FilesPatch %Lines
rollup/internal/controller/sender/sender.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## develop #1133 +/- ##
========================================
Coverage 57.07% 57.07% ========================================
Files 150 150 Lines 11203 11203 ========================================
Hits 6394 6394 Misses 4364 4364 Partials 445 445 
FlagCoverage Δ
rollup65.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xmountaintop
0xmountaintop merged commit e5e5caf into developFeb 19, 2024
@0xmountaintop
0xmountaintop deleted the fix-sender-panic-when-resubmitting-failed branch February 19, 2024 01:45
@coderabbitaicoderabbitaiBot mentioned this pull request Nov 17, 2025
13 tasks
@coderabbitaicoderabbitaiBot mentioned this pull request Nov 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingbump-versionBump the version tag for deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@colinlyguo@Thegaram@0xmountaintop