feat: set code tx support

[colinlyguo]

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change

Summary by CodeRabbit

• New Features

  • Transactions now include enhanced authorization details, offering richer context.

• Chores

  • Streamlined dependency management with various updates, additions, and removals to improve overall stability and performance.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request updates the dependency versions in the rollup/go.mod file by bumping, adding, and removing several packages. In addition, a new field, AuthorizationList, is added to the TransactionData structure in rollup/internal/controller/watcher/l2_watcher.go, where it is populated by invoking tx.SetCodeAuthorizations(). These changes adjust module compatibility and enhance transaction data details.

Changes

File(s)	Change Summary
rollup/go.mod	Updated dependency versions for github.com/scroll-tech/da-codec, github.com/scroll-tech/go-ethereum, and github.com/deckarep/golang-set; added new indirect dependencies (mmap-go, go-cmp, golang-lru, tsdb, notify, urfave/cli.v1); removed several indirect dependencies including CockroachDB packages, Sentry, flock, protobuf, jwt, x/tools, and lumberjack.
rollup/.../l2_watcher.go	Added AuthorizationList field to the TransactionData structure within the txsToTxsData function by calling tx.SetCodeAuthorizations().

Sequence Diagram(s)

sequenceDiagram
participant TX as Transaction
participant F as txsToTxsData Function
participant TD as TransactionData
TX->>F: Pass transaction
F->>TX: Call SetCodeAuthorizations()
TX-->>F: Return authorization list
F->>TD: Populate AuthorizationList
TD-->>F: Build complete transaction data

Loading

Possibly related PRs

• feat(bridge-history-api): update l2geth dependency for Pectra readiness #1601: Updates similar dependencies in the go.mod file, particularly for github.com/scroll-tech/da-codec and github.com/scroll-tech/go-ethereum.
• refactor: use new codec interfaces #1530: Involves modifications to the go.mod file with updates to dependency versions for github.com/scroll-tech/go-ethereum and github.com/scroll-tech/da-codec.

Suggested labels

bump-version

Suggested reviewers

• Thegaram
• georgehao
• 0xmountaintop

Poem

I'm a bright bunny with a hop in my stride,
Updating the code with a logical guide.
Dependencies bounce and auth fields bloom,
In a rhythm of change that clears up the room.
Hoppy coding days for all on this ride!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c07975a and 58c0e8e.

⛔ Files ignored due to path filters (2)

• go.work.sum is excluded by !**/*.sum
• rollup/go.sum is excluded by !**/*.sum

📒 Files selected for processing (5)

• common/version/version.go (1 hunks)
• rollup/go.mod (4 hunks)
• rollup/internal/controller/sender/sender.go (1 hunks)
• rollup/internal/controller/watcher/l1_watcher.go (1 hunks)
• rollup/internal/controller/watcher/l2_watcher.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• rollup/internal/controller/sender/sender.go

🧰 Additional context used

🪛 golangci-lint (1.62.2)

rollup/internal/controller/watcher/l1_watcher.go

8-8: "github.com/ethereum/go-ethereum/consensus/misc" imported and not used

(typecheck)

🔇 Additional comments (2)

common/version/version.go (1)

8-8: LGTM: Version increment for new feature.

Version bump from v4.4.87 to v4.4.88 aligns with the addition of set code transaction support.

rollup/internal/controller/watcher/l2_watcher.go (1)

103-121: LGTM: Added authorization list support.

The addition of AuthorizationList field and its initialization using SetCodeAuthorizations() properly implements the set code transaction support.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 51.72%. Comparing base (6b837c0) to head (f1418eb).

Files with missing lines	Patch %	Lines
rollup/internal/controller/watcher/l2_watcher.go	0.00%	17 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## develop #1600 +/- ##
===========================================
- Coverage 51.72% 51.72% -0.01% 
===========================================
Files 157 157 Lines 12555 12556 +1 ===========================================
Hits 6494 6494 - Misses 5497 5498 +1 
Partials 564 564 

Flag	Coverage Δ
rollup	56.98% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonastheis]

I think would be better to merge it into #1583 once scroll-tech/da-codec#43 is merged as well

[colinlyguo]

I think would be better to merge it into #1583 once scroll-tech/da-codec#43 is merged as well

what's the rationale for doing this? e.g. there seem no conflicts merging into develop and then merging develop in #1583.

[colinlyguo]

I think would be better to merge it into #1583 once scroll-tech/da-codec#43 is merged as well

what's the rationale for doing this? e.g. there seem no conflicts merging into develop and then merging develop in #1583.

changed the base branch to feat/use-codec-v6.