Skip to content

[Fix] Call GetL1Message in l2watcher - #1749

Merged
noel2004 merged 2 commits into
feat/cloakfrom
fix/cloak/l2watcher
Nov 11, 2025
Merged

[Fix] Call GetL1Message in l2watcher#1749
noel2004 merged 2 commits into
feat/cloakfrom
fix/cloak/l2watcher

Conversation

@noel2004

@noel2004noel2004 commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

We added a new RPC scroll_getL1MessagesInBlock in l2geth validium mode, however, this is not yet implemented in the Go SDK. As as simple workaround, this PR adds the ability to perform raw RPC calls, bypassing ethClient.

@coderabbitai

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cloak/l2watcher

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented Nov 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.50%. Comparing base (a7543d4) to head (32e208f).

Files with missing linesPatch %Lines
rollup/cmd/rollup_relayer/app/app.go0.00%4 Missing ⚠️
common/testcontainers/testcontainers.go62.50%2 Missing and 1 partial ⚠️
rollup/cmd/permissionless_batches/app/app.go0.00%3 Missing ⚠️
rollup/internal/controller/watcher/l2_watcher.go75.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## feat/cloak #1749 +/- ##
==============================================
- Coverage 36.77% 36.50% -0.28% 
==============================================
Files 247 247 Lines 21049 21186 +137 ==============================================
- Hits 7741 7733 -8 - Misses 12481 12630 +149 + Partials 827 823 -4 
FlagCoverage Δ
common29.69% <62.50%> (+0.15%)⬆️
coordinator32.37% <ø> (-0.42%)⬇️
database42.05% <ø> (ø)
rollup35.24% <27.27%> (-0.61%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noel2004
noel2004 merged commit 94dbf57 into feat/cloakNov 11, 2025
14 checks passed
@noel2004
noel2004 deleted the fix/cloak/l2watcher branch November 11, 2025 07:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@noel2004@codecov-commenter@Thegaram