Uh oh!
There was an error while loading. Please reload this page.
(libzkp): refactor batch header variants - #1755
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Purpose or design rationale of this PR
Incorporate refactoring changes proposed in scroll-tech/zkvm-prover#225.
This in addition to #1754 will avoid implementation confusion between
da-codecandzkvm-prover. Since da-codec v7, v8 and v9 are effectively identical (except the version byte), we cover all the 3 cases in a single umbrella variantV7_V8_V9and instead make use of theVersionto convey stf-version and codec-version.Before merging, we must wait for:
zkvm-provertag (rc.4) instead of depending onchore/galileo-refactor-headerBreaking change label
Does this PR have the
breaking-changelabel?