Fix mask_obs parameter resulting in underlying data being modified - #3496
Merged
flying-sheep merged 5 commits intoApr 14, 2025
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
==========================================
- Coverage 75.53% 75.18% -0.36%
==========================================
Files 113 113
Lines 13252 13253 +1
==========================================
- Hits 10010 9964 -46
- Misses 3242 3289 +47
|
Member
|
Thanks! |
flying-sheep
enabled auto-merge (squash)
April 14, 2025 12:41
flying-sheep
disabled auto-merge
April 14, 2025 12:41
flying-sheep
enabled auto-merge (squash)
April 14, 2025 12:41
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Apr 14, 2025
…lying data being modified
flying-sheep
pushed a commit
that referenced
this pull request
Apr 14, 2025
…ata being modified (#3587) Co-authored-by: Vishnu <me@vishnumenon.com>
selmanozleyen
pushed a commit
to selmanozleyen/scanpy
that referenced
this pull request
Apr 14, 2025
flying-sheep
pushed a commit
that referenced
this pull request
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mask_obsparameter modifies obs column when calling scatterplot #3400