Skip to content

Fix mask_obs parameter resulting in underlying data being modified - #3496

Merged
flying-sheep merged 5 commits into
scverse:mainfrom
vishnumenon:fix-mask_obs-data-mutation
Apr 14, 2025
Merged

Fix mask_obs parameter resulting in underlying data being modified#3496
flying-sheep merged 5 commits into
scverse:mainfrom
vishnumenon:fix-mask_obs-data-mutation

Conversation

@vishnumenon

@vishnumenon vishnumenon commented Mar 4, 2025

Copy link
Copy Markdown
Contributor
  • Release notes not necessary because:

@codecov

codecov Bot commented Mar 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (7baadb7) to head (de49c7c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   75.53%   75.18%   -0.36%     
==========================================
  Files         113      113              
  Lines       13252    13253       +1     
==========================================
- Hits        10010     9964      -46     
- Misses       3242     3289      +47     
Files with missing lines Coverage Δ
src/scanpy/plotting/_tools/scatterplots.py 84.51% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep added this to the 1.11.2 milestone Apr 14, 2025
@flying-sheep

Copy link
Copy Markdown
Member

Thanks!

@flying-sheep
flying-sheep enabled auto-merge (squash) April 14, 2025 12:41
@flying-sheep
flying-sheep disabled auto-merge April 14, 2025 12:41
@flying-sheep
flying-sheep enabled auto-merge (squash) April 14, 2025 12:41
@flying-sheep
flying-sheep merged commit f0f6960 into scverse:main Apr 14, 2025
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Apr 14, 2025
flying-sheep pushed a commit that referenced this pull request Apr 14, 2025
…ata being modified (#3587)

Co-authored-by: Vishnu <me@vishnumenon.com>
selmanozleyen pushed a commit to selmanozleyen/scanpy that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mask_obs parameter modifies obs column when calling scatterplot

2 participants