Skip to content

Add Pylint lints - #3577

Merged
flying-sheep merged 3 commits into
mainfrom
pa/pylint
Apr 11, 2025
Merged

Add Pylint lints#3577
flying-sheep merged 3 commits into
mainfrom
pa/pylint

Conversation

@flying-sheep

@flying-sheep flying-sheep commented Apr 11, 2025

Copy link
Copy Markdown
Member

@flying-sheep flying-sheep added Development Process 🚀 needs retroactive review This PR has been merged but could use some eyes on it labels Apr 11, 2025
@flying-sheep flying-sheep added this to the 1.11.2 milestone Apr 11, 2025
Comment on lines -461 to +459
for ikey, palette in zip(categoricals, palettes, strict=False):
for ikey, pal in zip(categoricals, palettes, strict=False):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLW2901 (redefined-loop-name) is great to disentangle hairy code!

@codecov

codecov Bot commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.82609% with 51 lines in your changes missing coverage. Please review.

Project coverage is 75.53%. Comparing base (8162c52) to head (7e9fe90).
Report is 44 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/plotting/_anndata.py 68.57% 11 Missing ⚠️
src/scanpy/plotting/_utils.py 70.27% 11 Missing ⚠️
src/scanpy/external/exporting.py 33.33% 4 Missing ⚠️
src/scanpy/plotting/_dotplot.py 60.00% 4 Missing ⚠️
src/scanpy/tools/_sim.py 42.85% 4 Missing ⚠️
src/scanpy/tools/_utils.py 85.18% 4 Missing ⚠️
src/scanpy/plotting/_tools/paga.py 62.50% 3 Missing ⚠️
src/scanpy/tools/_leiden.py 50.00% 3 Missing ⚠️
src/scanpy/tools/_top_genes.py 25.00% 3 Missing ⚠️
src/scanpy/_utils/__init__.py 75.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
+ Coverage   75.48%   75.53%   +0.05%     
==========================================
  Files         113      113              
  Lines       13169    13147      -22     
==========================================
- Hits         9941     9931      -10     
+ Misses       3228     3216      -12     
Files with missing lines Coverage Δ
src/scanpy/_settings.py 89.55% <100.00%> (ø)
...c/scanpy/experimental/pp/_highly_variable_genes.py 62.73% <100.00%> (ø)
src/scanpy/experimental/pp/_recipes.py 100.00% <100.00%> (ø)
src/scanpy/external/pl.py 33.68% <100.00%> (ø)
src/scanpy/external/pp/_bbknn.py 53.84% <100.00%> (ø)
src/scanpy/external/pp/_dca.py 50.00% <100.00%> (ø)
src/scanpy/external/pp/_hashsolo.py 88.23% <100.00%> (ø)
src/scanpy/external/pp/_magic.py 78.04% <100.00%> (ø)
src/scanpy/external/pp/_mnn_correct.py 22.22% <100.00%> (ø)
src/scanpy/external/tl/_phate.py 39.13% <100.00%> (ø)
... and 46 more

@flying-sheep
flying-sheep merged commit bf20d70 into main Apr 11, 2025
@flying-sheep
flying-sheep deleted the pa/pylint branch April 11, 2025 12:58
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Apr 11, 2025
flying-sheep added a commit that referenced this pull request Apr 11, 2025
Co-authored-by: Philipp A <flying-sheep@web.de>
selmanozleyen pushed a commit to selmanozleyen/scanpy that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development Process 🚀 needs retroactive review This PR has been merged but could use some eyes on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant