Skip to content

Catch all exceptions getting version from VCS, fallback to importlib - #3615

Merged
flying-sheep merged 1 commit into
scverse:mainfrom
rgoya:catch_all_exceptions_getting_version
Apr 29, 2025
Merged

Catch all exceptions getting version from VCS, fallback to importlib#3615
flying-sheep merged 1 commit into
scverse:mainfrom
rgoya:catch_all_exceptions_getting_version

Conversation

@rgoya

@rgoya rgoya commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

scanpy has the same issue reported for anndata here scverse/anndata#1960 and fixed here scverse/anndata#1972

Mainly, the _get_version_from_vcs() function in src/scanpy/_version.py breaks when the user has hatchling installed and a pyproject.toml file is found, but cannot be parsed by hatch/hatchling.

This fix is a replicate of scverse/anndata#1972, with _PROJECT_NAME = "scanpy"

  • Release notes not necessary because:

@flying-sheep

Copy link
Copy Markdown
Member

Thanks!

@flying-sheep
flying-sheep merged commit 813608e into scverse:main Apr 29, 2025
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Apr 29, 2025
flying-sheep pushed a commit that referenced this pull request Apr 29, 2025
…lback to `importlib` (#3616)

Co-authored-by: Rodrigo Goya <rgoya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants