Skip to content

Updated starter code - #2

Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom
sagar87:main
Closed

Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom
sagar87:main

Conversation

@sagar87

@sagar87sagar87 commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API

@review-notebook-app

review-notebook-appBot commented Jan 27, 2023

Copy link
Copy Markdown

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@timtreistimtreis mentioned this pull request May 11, 2026
Merged
@timtreistimtreis mentioned this pull request Jun 6, 2026
Closed
timtreis added a commit that referenced this pull request Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Updated starter code by sagar87 · Pull Request #2 · scverse/spatialdata-plot · GitHub
Skip to content
Updated starter code - #2
Closed
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Closed
Updated starter code#2
sagar87 wants to merge 4 commits into
scverse:mainfrom 
sagar87:main
Conversation
@sagar87
@sagar87sagar87
commented
Jan 27, 2023

Copy link


Copy Markdown

Collaborator
  • contains a very basic implementation of the spatialdata_plotting.pp module
  • a jupyter notebook with some examples illustrating the API
@review-notebook-app
review-notebook-appBot
commented
Jan 27, 2023

Copy link


Copy Markdown

Check out this pull request on ReviewNB
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@timtreistimtreis
mentioned this pull request
May 11, 2026
 Merged

@timtreistimtreis
mentioned this pull request
Jun 6, 2026

Closed

timtreis added a commit
that referenced
this pull request
Jun 9, 2026
@timtreis
Address review blockers in measure_obs (#1-#5,#7)
398fa05
- #1 no-clobber: a populated obsm["spatial"] (reader- or prior-call-provided)
is no longer overwritten — warn and skip that element's centroids. Coords
stay in the element's intrinsic pixel space (documented); area/diameter
still overwrite our own columns. Restores the per-element finiteness guard.
- #2 unmatched instance ids: instances annotated in the table but absent from
the element (e.g. str-vs-int id dtype mismatch) now warn instead of silently
writing NaN.
- #3 float-dtype labels: the dense relabelling bincounts integer searchsorted
indices, never the raw labels, so a float-typed (integer-valued) mask no
longer crashes np.bincount.
- #4 atomic writes: validate every obs target (non-numeric column collision)
before the first mutation, so a bad column never leaves a half-written table.
- #5 O(n_labels) memory: relabel labels to a dense 0..k-1 range, so the
aggregator's memory scales with the number of distinct labels, not the
maximum label id (sparse/global ids no longer blow it up). Single max() pass
replaced by a unique() pass; same pass count.
- #7 circle area: dispatch on geometry TYPE (all-Point) rather than the
presence of a "radius" column, so a polygon element carrying a radius column
uses geometry.area, not pi*r**2.
Tests updated to the new contract and extended for each fix.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@sagar87@timtreis