Pass docs by melonora · Pull Request #237 · scverse/spatialdata-plot

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora · 2024-04-01T11:31:06Z

Follow up on #236. This PR is a pass on the docs. The type hints have been updated to the last status. Currently pl.show is missing some docstrings, but due the behaviour not being completely correct I kept these arguments out for now.

codecov-commenter · 2024-04-01T11:34:56Z

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 77.70%. Comparing base (9ddebfe) to head (8d67a4b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #237 +/- ##
==========================================
- Coverage 78.01% 77.70% -0.32% 
==========================================
Files 11 11 Lines 1710 1722 +12 ==========================================
+ Hits 1334 1338 +4 - Misses 376 384 +8

Files	Coverage Δ
src/spatialdata_plot/pl/basic.py	`91.39% <ø> (ø)`
src/spatialdata_plot/pl/render.py	`94.61% <100.00%> (ø)`
src/spatialdata_plot/pl/render_params.py	`100.00% <100.00%> (ø)`
src/spatialdata_plot/pl/utils.py	`66.70% <45.00%> (-0.43%)`	⬇️

giovp

only a minor thing on docstrings, but it would be nice to also have real world example (small ones, self contained, maybe with blobs datasets)to explain the different logic cause it gets quite complicated (list of lists?)

giovp · 2024-04-03T15:48:20Z

- Can either be a color-like or a key in :attr:`sdata.table.obs`. The latter
- can be used to color by categorical or continuous variables.
+ color : list[str | None] | str | None
+ Can either be string(s) representing a color-like or key(s) in :attr:`sdata.table.obs`. The latter


I don't think it can be stuff in adata.obs, as points are not annotated by tables

also below, is this correct? I don't think so,I think it was copy pasted?

hehe points now can be annotated by tables and I agree on tests, still have to write them. In general also a lot of the notebooks have plots that have no equivalent tests here so before a lot of them were not properly showing either. However, for release it was pushed. The logic of this library is quite complicated with some parameters with the same name are used in different ways that it took me quite some time so at the moment I did the testing by checking whether all the notebook plots now display correctly.

for more information, see https://pre-commit.ci

LucaMarconato · 2024-04-05T20:18:50Z

Thanks, merging now. Please note that specifying the type and the default values after the parameters list in the docstring is not required since this is automatically inferred by sphinx. Not worth to remove the old ones, but I'd suggest not to keep adding them in new functions. @melonora @timtreis. CC @giovp

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

melonora added 4 commits April 1, 2024 00:54

fix var colorbar labels
f0452d4

fix var plotting in case of vector length 3/4
6f63830

fix tests
9445e36

pass on docs
1c6cccb

melonora mentioned this pull request Apr 1, 2024
Fix var plotting #236
Merged

giovp self-requested a review April 3, 2024 14:00

melonora added 2 commits April 3, 2024 16:07

fix issue palette_input
925a3db

revert
9760451

giovp mentioned this pull request Apr 3, 2024
add xenium example scverse/spatialdata-tutorials#94
Merged

set palette default to lightgray
6f3375b

giovp approved these changes Apr 3, 2024
View reviewed changes

melonoraand others added 9 commits April 4, 2024 16:54

fix adding same na_color and default palette
998e3c6

address comments
3d68be0

remove unnecessary check
5793bf2

more informative name
c33f84a

fix prettier
56ed753

Merge branch 'main' into fix_var_plotting
46448b9

Merge branch 'fix_var_plotting' into pass_docs
8d67a4b

docstring change on fill_alpha
948d955

[pre-commit.ci] auto fixes from pre-commit.com hooks
77aac0f
for more information, see https://pre-commit.ci

LucaMarconato merged commit e0487bd into scverse:mainApr 5, 2024

Uh oh!

Conversation

melonora commented Apr 1, 2024

Uh oh!

codecov-commenter commented Apr 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

giovp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LucaMarconato commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

melonora commented Apr 1, 2024

Uh oh!

codecov-commenter commented Apr 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

giovp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LucaMarconato commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

melonora commented Apr 1, 2024

Uh oh!

codecov-commenter commented Apr 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

giovp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LucaMarconato commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecov-commenter commented Apr 1, 2024•
edited
Loading

codecov-commenter commented Apr 1, 2024•
edited
Loading

codecov-commenter commented Apr 1, 2024•
edited
Loading

codecov-commenter commented Apr 1, 2024•
edited
Loading

codecov-commenter commented Apr 1, 2024•
edited
Loading