Uh oh!
There was an error while loading. Please reload this page.
Added utils function for 0-transparent cmaps - #302
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #302 +/- ##
==========================================
+ Coverage 80.18% 80.35% +0.17%
==========================================
Files 11 11 Lines 1736 1746 +10 ==========================================
+ Hits 1392 1403 +11 + Misses 344 343 -1
🚀 New features to boost your workflow:
|
LucaMarconato
commented
Jul 14, 2024
Amazing! Ready for review? |
timtreis
commented
Jul 14, 2024
Added the function @LucaMarconato@giovp. Probably best to add it to one of the notebooks to illustrate usage - which one do you think would be best? |
LucaMarconato
commented
Jul 14, 2024
Thanks! I am working on the Visium HD notebook right now, so I can add it there 😊 |
for more information, see https://pre-commit.ci
…alpha=0' of github.com:scverse/spatialdata-plot into feature/issue242-modify-colormap-so-that-0-values-have-alpha=0
melonora
left a comment
There was a problem hiding this comment.
LGTM! Maybe one consideration is to add a parameter that automatically does this for the user e,g, zero_transparent, but this could be added in a different PR. Also this PR does make it a bit more difficult for view configurations as we are dealing with different alpha values. May have to think of serialization of the colormap values.
timtreis
commented
Jul 15, 2024
Yeah, based on #242 we decided not to include it as an argument but like this. But I agree, eventually, we should probably just serialise the data. I think ggplot f.e. also does it like this when generating the plot |
Note: the only existing utils function was using a different testing pattern, which I now aligned with the usual one. But therefore there's an additonal image in this PR