refactor(render_params): RenderParams base class for the 5 *RenderParams by timtreis · Pull Request #720 · scverse/spatialdata-plot

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis · 2026-06-14T21:06:11Z

Step 1 of #700 — the low-risk, internal-only piece of the RenderParams→IR architecture epic. The IR phases (Steps 2+) remain a discussion pending maintainer sign-off and are not in this PR.

What & why

The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. This hoists them into a @dataclass(kw_only=True) class RenderParams; the five become thin (RenderParams) subclasses carrying only their renderer-specific fields.

Only these four are genuinely universal. cmap_params exists on all five but with three different types (CmapParams / list[CmapParams] | CmapParams / CmapParams | None), and the color/groups/table_name/col_for_color/table_layer cluster is not shared by all renderers (Image lacks the color cluster; Graph lacks col_for_color/table_layer) — so those stay on the subclasses rather than being forced into the base with inert/over-wide fields.

…rParams (#700) Step 1 of the #700 architecture epic (the low-risk, internal-only piece). The five *RenderParams dataclasses each redeclared the four fields that are universal with identical type+default: element, zorder, colorbar, colorbar_params. Hoist them into a `@dataclass(kw_only=True) class RenderParams`; the five become thin `(RenderParams)` subclasses keeping only their renderer-specific fields. - kw_only=True is required on the base (a required `element` precedes the defaulted fields) and applied uniformly for a consistent convention; all construction sites in basic.py already pass every field by keyword. - Behaviour/pixel preserving: each subclass exposes the exact same field set (name/type/default) as before — only the declaration moved. cmap_params stays on the subclasses (its type varies: CmapParams / list|CmapParams / CmapParams|None), as do color/groups/table_name etc. (Image/Graph differ). - Internal only; not part of the public API. Adds tests/pl/test_render_params.py locking the hierarchy and a frozen per-subclass field-name snapshot (a dropped field or flipped default is invisible to the CI-only image baselines, so it is asserted directly). Steps 2+ (resolve -> IR -> backend) remain a discussion pending maintainer sign-off; sequence after #696 and #699 land.

codecov-commenter · 2026-06-14T21:11:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (7a1b3a3) to head (7d91a2a).

Additional details and impacted files

@@ Coverage Diff @@## main #720 +/- ##
==========================================
- Coverage 77.18% 77.11% -0.08% 
==========================================
Files 14 14 Lines 4440 4426 -14 Branches 1014 1014 ==========================================
- Hits 3427 3413 -14 
Misses 658 658 Partials 355 355

Files with missing lines	Coverage Δ
src/spatialdata_plot/pl/render_params.py	`88.36% <100.00%> (-0.67%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… + single continuous-norm (#699) PRs 1+2 of #699, rebased onto the post-#715 (utils split) / post-#720 main. PR3 (image-composite helper) deferred. CmapParams gains behavior: - fresh_norm(): a safe per-element copy (applying a Normalize autoscales vmin/vmax in place, leaking one element's range into the next). Converts the 3 copy(norm) sites in render.py. - cmap_with_alpha() / colormap_with_alpha(): public-API replacement for the private cmap._lut[:, -1] = alpha poke in the 1-channel image path; byte-identical body colors, no shared-cmap mutation. Single continuous-norm feeds pixels and colorbar: - _resolve_continuous_norm(values, cmap_params) in _color.py: one resolver called by each pixel-baking site and its matching colorbar site with the same vector, so they cannot diverge. Folds the duplicated inline norm blocks in _color_vector_to_rgba and _get_collection_shape (now in _geometry.py; its dead `norm` param dropped) and routes _map_color_seg + the labels imshow + _append_outline_colorbar + the shapes set_clim through it. - Datashader / image / points / graph paths unchanged (already share their norm). Behavior-preserving for normal renders; the only unified edge is an all-identical-value outline column. Adds unit tests for the new CmapParams methods and _resolve_continuous_norm plus a non-visual colorbar-clim integration test.

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

timtreis changed the title ~~refactor(render_params): RenderParams base class for the 5 *RenderParams (#700, Step 1)~~refactor(render_params): RenderParams base class for the 5 *RenderParamsJun 14, 2026

timtreis mentioned this pull request Jun 14, 2026
Architecture: RenderParams base class -> formal IR (resolve -> IR -> backend) #700
Closed

timtreis merged commit 78f02f8 into mainJun 14, 2026
7 of 8 checks passed

timtreis added the release-changed label Jun 14, 2026

This was referenced Jun 14, 2026
refactor: unify color/cmap/norm pipeline — CmapParams methods + single continuous-norm #721
Merged
refactor(color): ColorSpec - typed color-state boundary #722
Merged

timtreis deleted the refactor/issue-700-renderparams-ir branch July 10, 2026 11:11

Uh oh!

Conversation

timtreis commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Uh oh!

codecov-commenter commented Jun 14, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timtreis commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Uh oh!

codecov-commenter commented Jun 14, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timtreis commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Uh oh!

codecov-commenter commented Jun 14, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timtreis commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Uh oh!

codecov-commenter commented Jun 14, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

timtreis commented Jun 14, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What & why

Uh oh!

codecov-commenter commented Jun 14, 2026

Codecov Report

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading

timtreis commented Jun 14, 2026•
edited
Loading