Uh oh!
There was an error while loading. Please reload this page.
Sync with 3.29.0 - #406
Merged
Merged
Conversation
dkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
3 times, most recently
from
January 5, 2025 16:15
270d2f5 to
d9ffed0Comparedkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
from
January 26, 2025 19:10
d9ffed0 to
6d08a73Comparedkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
2 times, most recently
from
February 21, 2025 20:36
e0f3caf to
85999e3Comparedkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
11 times, most recently
from
February 22, 2025 15:49
1eedd4a to
5d0a93dComparedkropachev
marked this pull request as ready for review
February 22, 2025 17:53
dkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
from
February 23, 2025 11:17
5d0a93d to
2245492Comparedkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
4 times, most recently
from
February 23, 2025 13:00
7ef3a9c to
3c06734Comparedkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
2 times, most recently
from
February 23, 2025 13:29
551f37f to
85a40baCompareOriginal commit c9b24b7 made it not install certain modules on python 3.13 because at the time python was broken and did not support these modules, now they work ok, roll it back.
dkropachevforce-pushed
the
dk/sync-with-3.29.0
branch
from
February 23, 2025 15:39
85a40ba to
68bf8a7Compareroydahan
commented
Feb 23, 2025
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with 3.29.0 of the upstream
One significant refactor needed to make it work, after c44e264 multiple test become broken, this commit introduced
DependencyExceptionfor missing requirements forasyncorereactor.pyandlibevreactor.pyand partially patched code thatimports them, as result many tests where broken.
I have created following up commit that addresses all the problems: 47d882d
Pre-review checklist
I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.