Skip to content

shard aware: Move ShardInfo class into a Cython - #48

Merged
fruch merged 2 commits into
scylladb:masterfrom
fruch:cython_shared_aware
Jun 30, 2020
Merged

shard aware: Move ShardInfo class into a Cython#48
fruch merged 2 commits into
scylladb:masterfrom
fruch:cython_shared_aware

Conversation

@fruch

Copy link
Copy Markdown

since the computation was quite naive to begin with and in pure python
we could do much better with a calculation purely in C.

@fruch
fruch requested review from dkropachev and ultrabugJune 29, 2020 15:13

@ultrabugultrabug left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be a good optimization

@fruch
fruchforce-pushed the cython_shared_aware branch 7 times, most recently from ebc386f to 694d302CompareJune 30, 2020 13:39

@dkropachevdkropachev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on cython, LGTM.

@fruch
fruchforce-pushed the cython_shared_aware branch from 694d302 to aa6db57CompareJune 30, 2020 17:05
since the computation was quite naive to begin with and in pure python
we could do much better with a calculation purely in C.
@fruch
fruchforce-pushed the cython_shared_aware branch from aa6db57 to 59c9b54CompareJune 30, 2020 17:19
@fruch

Copy link
Copy Markdown
Author

Not an expert on cython, LGTM.

No one is :)

seem like it even fix the windows issue
@fruch
fruchforce-pushed the cython_shared_aware branch from 52061bb to 5fc4b74CompareJune 30, 2020 18:56
@fruch
fruch merged commit ca35809 into scylladb:masterJun 30, 2020
@fruch
fruch deleted the cython_shared_aware branch June 30, 2020 21:09
tzach pushed a commit to tzach/python-driver that referenced this pull request Aug 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@fruch@ultrabug@dkropachev