perf: inline row decoding and eliminate closures in recv_results_rows (100's to 1000's of ns, x1.3-1.8 speedup, Python only)

[mykaul]

Summary

• Split recv_results_rows into fast path (no column encryption) and slow path (CE enabled)
• Eliminate per-call closure allocation and merge two-pass row processing into single-pass decoding

Note: This optimization applies to the pure Python decode path only. When Cython extensions are compiled (the default for pip-installed packages), FastResultMessage from row_parser.pyx replaces recv_results_rows entirely. Users running without Cython (e.g., environments where C compilation is unavailable, or explicit use of _ProtocolHandler) will benefit from this change.

Details

Problem

The current recv_results_rows has three sources of overhead on every call:

1. Two passes over row data: First recv_row reads all raw bytes into a list[list[bytes]], then decode_row iterates again to deserialize — doubling iteration and creating intermediate lists that are immediately discarded.

2. Per-call closures: decode_val and decode_row are defined as closures inside recv_results_rows, meaning Python allocates new function objects on every result set.

3. Unconditional ColDesc creation: ColDesc namedtuples are built for every column even when column encryption is not configured (the vast majority of deployments).

Solution

Fast path (no column encryption — the common case):

• _decode_row_inline(f, colcount, col_types, protocol_version) reads each column's size, reads the bytes, and immediately calls from_binary() — one pass, no intermediate list
• ColDesc creation is skipped entirely
• No closures allocated

Slow path (column encryption enabled):

• Preserves the existing two-pass logic (needed because CE must decrypt before type decoding)
• decode_val/decode_row moved to module-level functions (_decode_val_ce, _decode_row_ce) to avoid per-call closure overhead

Benchmark results

Measured on CPython 3.14.3, Protocol V4, 300 iterations, 100 warmup. All values in nanoseconds per row.

Scenario	Master (min ns/row)	PR (min ns/row)	Master (median ns/row)	PR (median ns/row)	Speedup (min)	Speedup (median)
5 int cols, 10 rows	2677	1911	3192	2558	1.40x	1.25x
5 int cols, 100 rows	2155	1489	2877	1908	1.45x	1.51x
5 int cols, 1000 rows	2675	1848	3165	2260	1.45x	1.40x
5 mixed cols, 100 rows	2625	2024	3225	2203	1.30x	1.46x
5 mixed cols, 1000 rows	2942	1926	3880	2118	1.53x	1.83x
10 int cols, 100 rows, 50% NULL	4666	3095	5284	3314	1.51x	1.59x
10 int cols, 1000 rows, 50% NULL	4812	2737	6156	3166	1.76x	1.94x
10 int cols, 100 rows, no NULL	5082	3826	5339	4201	1.33x	1.27x
10 int cols, 1000 rows, no NULL	5116	3647	6184	4589	1.40x	1.35x

1.3x–1.8x speedup on the pure Python path. The speedup is higher with NULL-heavy workloads because the inline path short-circuits from_binary() for negative-length (NULL) columns.

Merge conflict note

⚠️ This PR modifies the same recv_results_rows method as PR #630, which also splits the method into CE/non-CE branches. If both PRs are accepted, there will be a merge conflict requiring manual resolution.

Testing

• All 651 existing unit tests pass (16 pre-existing skips)
• Added test for decode error wrapping in the inline path (test_protocol.py)

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c697dc74-3211-4d7c-b525-5189e8d082e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Optimizes pure-Python result-row decoding while preserving the column-encryption path.

Changes:

• Decodes unencrypted rows in one pass without intermediate lists or closures.
• Moves encrypted-column decoding helpers to module scope.
• Adds coverage for inline decoding error messages.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
cassandra/protocol.py	Implements optimized row decoding paths.
tests/unit/test_protocol.py	Tests inline decode error wrapping.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.