Skip to content

cluster: use dynamic whitelist policy for proxy access - #833

Closed
dkropachev wants to merge 14 commits into
masterfrom
dk/fix-for-proxy-access-2
Closed

cluster: use dynamic whitelist policy for proxy access#833
dkropachev wants to merge 14 commits into
masterfrom
dk/fix-for-proxy-access-2

Conversation

@dkropachev

@dkropachevdkropachev commented Apr 23, 2026

Copy link
Copy Markdown

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

github-code-quality[bot]
github-code-qualityBot found potential problems Apr 23, 2026
View reviewed changes
Comment threadtests/unit/test_cluster.py Fixed
Comment threadtests/unit/test_cluster.py Fixed
Comment threadcassandra/cluster.py Fixed
@dkropachev
dkropachevforce-pushed the dk/fix-for-proxy-access-2 branch from 679a13f to ab38a22CompareApril 26, 2026 12:24
github-code-quality[bot]
github-code-qualityBot found potential problems Apr 26, 2026
View reviewed changes
Comment threadtests/unit/test_cluster.py Fixed
Comment threadtests/unit/test_cluster.py Fixed
Comment threadcassandra/cluster.py Fixed
@dkropachev
dkropachevforce-pushed the dk/fix-for-proxy-access-2 branch from ab38a22 to 3b6c175CompareApril 28, 2026 13:54
github-code-quality[bot]
github-code-qualityBot found potential problems Apr 28, 2026
View reviewed changes
Comment threadcassandra/cluster.py Fixed
@roydahanroydahan mentioned this pull request May 4, 2026
Closed
@dkropachev
dkropachevforce-pushed the dk/fix-for-proxy-access-2 branch from 3b6c175 to a4147e2CompareMay 4, 2026 15:55
github-code-quality[bot]
github-code-qualityBot found potential problems May 4, 2026
View reviewed changes
Comment threadcassandra/cluster.py Fixed
This was referenced May 4, 2026
Merged
Merged
@fruch

fruch commented May 4, 2026

Copy link
Copy Markdown

I can confirm taking this PR in scylladb/scylla-cluster-tests#14512, and it worked as expected via public address

github-code-quality[bot]
github-code-qualityBot found potential problems May 5, 2026
View reviewed changes
Comment threadtests/unit/test_cluster.py Fixed
Comment threadcassandra/policies.py Fixed
Comment threadcassandra/policies.py Fixed
Comment threadcassandra/policies.py Fixed
Comment threadcassandra/cluster.py Fixed
@dkropachev
dkropachevforce-pushed the dk/fix-for-proxy-access-2 branch from fab5d7b to be1794dCompareMay 5, 2026 20:16
github-code-quality[bot]
github-code-qualityBot found potential problems May 5, 2026
View reviewed changes
Comment threadtests/unit/test_cluster.py Fixed
Comment threadcassandra/cluster.py Fixed
@dkropachev
dkropachevforce-pushed the dk/fix-for-proxy-access-2 branch from be1794d to 589a752CompareMay 5, 2026 20:43
github-code-quality[bot]
github-code-qualityBot found potential problems May 5, 2026
View reviewed changes
Comment threadtests/unit/test_cluster.py
@mock_session_pools
def test_session_preserves_down_event_discounting_after_endpoint_update(self, *_):
@total_ordering
class _DeterministicHashEndPoint(EndPoint):
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request May 11, 2026
@fruch
feature(cluster): use DynamicWhiteListRoundRobinPolicy for public add…
c943ce7
…ress connections
Switch python-driver to PR scylladb/python-driver#833 branch which
introduces DynamicWhiteListRoundRobinPolicy. When SCT connects via
public addresses (IP_SSH_CONNECTIONS == "public"), use this policy
instead of WhiteListRoundRobinPolicy.
DynamicWhiteListRoundRobinPolicy dynamically tracks which host the
control connection resolves to and only routes queries there, solving
the problem where the driver discovers private IPs from system tables
that are unreachable from the client when using public/proxy access.
@dkropachev

dkropachev commented May 11, 2026

Copy link
Copy Markdown
Author

Change is too intrusive, given pre-existing mess in node status handling it will only contribute to it, we found easier solution - #878, this PR is closed

@scylladbbotscylladbbot mentioned this pull request May 12, 2026
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-code-qualitygithub-code-quality[bot]github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkropachev@fruch