Fixed module name inconsistency in typescript defintions - #3
Closed
fela98 wants to merge 2 commits into
Closed
Conversation
NicoAiko
commented
Mar 23, 2020
@sdnetwork ehm. What's the status here? |
NicoAiko
commented
Mar 23, 2020
@fela98 Is there a reason why you set the encoding to |
sdnetwork
commented
Mar 23, 2020
Owner
For me no reason to change default encoding ! @fela98 why this change ? |
Author
Hi, Sorry Such a long time ago that I forgot this PR and pushed more to my master. Use new PR #4 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves typescript error.