750: Teach ad-hoc hooks line parsing - #757
Conversation
sds
left a comment
There was a problem hiding this comment.
Thanks so much for opening this pull request, @guillaume-d. Very excited to move this forward.
Left a few comments to clarify how we could potentially make this experience a seamless one without having to introduce the concept of an "ad hoc" hook to the configuration format. Curious to get your perspective.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sds
left a comment
There was a problem hiding this comment.
Sincere apologies for the very slow response, @guillaume-d. Let me know your thoughts!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
guillaume-d
commented
Jul 16, 2021
No problem, was started to worry something bad may have happened. |
1438fa3 to
34bf2c8Comparef5f0d60 to
72ed54fCompare72ed54f to
3dc1d14Compareguillaume-d
commented
Oct 11, 2021
Hi. I think all comments have finally been adressed now. I am afraid I will not have much more time to do another review round (except maybe if feedback is very minor and comes fast, before I get sidetracked by other things). If nothing comes I will just use my fork of overcommit going forward, and use #758 and future uses of this feature from there. |
Include some (partly regression) tests and a small doc.