Skip to content

fix: Handle non-json error responses - #263

Merged
andrii-balitskyi merged 7 commits into
mainfrom
andrii/cx-121-handle-non-json-error-response
Feb 13, 2025
Merged

fix: Handle non-json error responses#263
andrii-balitskyi merged 7 commits into
mainfrom
andrii/cx-121-handle-non-json-error-response

Conversation

@andrii-balitskyi

@andrii-balitskyiandrii-balitskyi commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@andrii-balitskyi
andrii-balitskyi requested a review from a team as a code ownerFebruary 12, 2025 15:37
andrii-balitskyi
andrii-balitskyi commented Feb 12, 2025
View reviewed changes
Comment threadseam/client.py
@razor-x

razor-x commented Feb 12, 2025

Copy link
Copy Markdown
Member

@andrii-balitskyi we should be able to write a test for this at least for one case
https://github.com/seamapi/javascript-http/blob/12a2198c70bd3e2477de5591fdb2014ee3f486eb/test/seam/connect/http-error.test.ts#L12

razor-x
razor-x reviewed Feb 12, 2025
View reviewed changes
Comment threadseam/client.py Outdated
@andrii-balitskyi

andrii-balitskyi commented Feb 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@razor-x here's the test 0204dce

@andrii-balitskyiandrii-balitskyi self-assigned this Feb 12, 2025
@razor-xrazor-x changed the title Handle non-json error responsesfix: Handle non-json error responsesFeb 12, 2025
@andrii-balitskyi
andrii-balitskyi merged commit 71cb656 into mainFeb 13, 2025
@andrii-balitskyi
andrii-balitskyi deleted the andrii/cx-121-handle-non-json-error-response branch February 13, 2025 14:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razor-xrazor-xrazor-x approved these changes

Assignees

@andrii-balitskyiandrii-balitskyi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrii-balitskyi@razor-x