Skip to content

Fix failed action attempt handling, add custom action attempt errors - #61

Merged
andrii-balitskyi merged 12 commits into
mainfrom
action-attempt-error-handling
Aug 2, 2024
Merged

Fix failed action attempt handling, add custom action attempt errors#61
andrii-balitskyi merged 12 commits into
mainfrom
action-attempt-error-handling

Conversation

@andrii-balitskyi

@andrii-balitskyiandrii-balitskyi commented Jul 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Move http errors to new seam/errors.rb
  • Add action attempt errors and use them
  • Correctly handle error action attempts
  • Ensure default values for timeout and polling_interval are used in wait_until_finished
  • Default wait_for_action_attempt client setting to true
  • Fix error action attempt handling
  • Add wait_for_action_attepmt_spec.rb

@andrii-balitskyiandrii-balitskyi changed the title Fix error action attempt handling, add custom action attempt errorsFix error action attempt poll handling, add custom action attempt errorsJul 26, 2024
@andrii-balitskyiandrii-balitskyi changed the title Fix error action attempt poll handling, add custom action attempt errorsFix error action attempt handling, add custom action attempt errorsJul 26, 2024
@andrii-balitskyiandrii-balitskyi changed the title Fix error action attempt handling, add custom action attempt errorsFix failed action attempt handling, add custom action attempt errorsJul 26, 2024
razor-x
razor-x reviewed Jul 29, 2024
View reviewed changes
Comment threadlib/seam/errors.rb
Comment threadlib/seam/request.rb
Comment threadspec/seam_client/wait_for_action_attepmt_spec.rb
@andrii-balitskyiandrii-balitskyi mentioned this pull request Jul 30, 2024
Open
@andrii-balitskyi
andrii-balitskyiforce-pushed the action-attempt-error-handling branch 2 times, most recently from 7df4572 to 0e79fccCompareJuly 30, 2024 15:16
@andrii-balitskyi
andrii-balitskyi merged commit 4e36056 into mainAug 2, 2024
@andrii-balitskyi
andrii-balitskyi deleted the action-attempt-error-handling branch August 2, 2024 08:28
@razor-xrazor-x mentioned this pull request Aug 5, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razor-xrazor-xAwaiting requested review from razor-x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrii-balitskyi@razor-x