Skip to content

Drop the npm registry setup from the release workflow - #159

Merged
sdivelbiss merged 1 commit into
masterfrom
scott/seats-1209-node_auth_token-needs-updating-in-seatsio-python
Aug 24, 2026
Merged

Drop the npm registry setup from the release workflow#159
sdivelbiss merged 1 commit into
masterfrom
scott/seats-1209-node_auth_token-needs-updating-in-seatsio-python

Conversation

@sdivelbiss

@sdivelbisssdivelbiss commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

we never publish to npm here, removing the registry setup

CopilotAI lite review requested due to automatic review settings August 24, 2026 19:30

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes npm registry configuration from the GitHub Actions release workflow to avoid setup-node@v7 auth-token behavior breaking yarn add, aligning with this repo’s release process (PyPI publish; Node is only used to run zx).

Changes:

  • Dropped registry-url: https://registry.npmjs.org/ from the actions/setup-node@v7 step in the release workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sdivelbiss
sdivelbiss marked this pull request as ready for review August 24, 2026 19:33
@sdivelbiss
sdivelbiss requested a review from a team as a code ownerAugust 24, 2026 19:33
@sdivelbiss
sdivelbiss requested review from bverbeken, mroloux and schaloner and removed request for a teamAugust 24, 2026 19:33
@sdivelbissLinear Code

Copy link
Copy Markdown
ContributorAuthor

woah! late night approval!

@sdivelbiss
sdivelbiss merged commit 528b053 into masterAug 24, 2026
3 checks passed
@sdivelbiss
sdivelbiss deleted the scott/seats-1209-node_auth_token-needs-updating-in-seatsio-python branch August 24, 2026 23:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sdivelbiss@mroloux