Add `enable` option to disable flushing by wlingke · Pull Request #158 · segmentio/analytics-node

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke · 2018-02-24T21:35:25Z

Addresses #116, follow up from #118

codecov-io · 2018-02-24T21:40:06Z

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #158 +/- ##
=====================================
Coverage 100% 100% =====================================
Files 1 1 Lines 97 102 +5 =====================================
+ Hits 97 102 +5

Impacted Files	Coverage Δ
index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a9ed...662fec7. Read the comment docs.

vadimdemedes · 2018-02-26T06:32:43Z

+ configurable: false,
+ writable: false,
+ enumerable: true,
+ value: options.enable === false ? options.enable : true


Could you replace that with typeof options.enable === 'boolean'?

wlingke · 2018-02-26T15:57:12Z

Isn't what's there and what you're suggesting the same outcome?

…

On Sun, Feb 25, 2018 at 10:32 PM, Vadim Demedes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#158 (comment)> : > @@ -38,6 +39,12 @@ class Analytics { this.flushAt = Math.max(options.flushAt, 1) || 20 this.flushInterval = options.flushInterval || 10000 this.flushed = false + Object.defineProperty(this, 'enable', { + configurable: false, + writable: false, + enumerable: true, + value: options.enable === false ? options.enable : true Could you replace that with typeof options.enable === 'boolean'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#158 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC__QKDqa_2DE7HEUL_lK1I06JzKKi1Kks5tYlAOgaJpZM4SSDgS> .

vadimdemedes · 2018-02-27T08:18:02Z

Yes, the outcome is the same, but that code reads differently and is quicker to understand its purpose.

wlingke · 2018-02-27T18:18:07Z

Okay updated

vadimdemedes · 2018-02-28T08:45:13Z

@wlingke Thanks!
@f2prateek Could you publish a new minor version? I don't have publish access to this package.

f2prateek · 2018-03-03T00:08:35Z

Released in 3.3.0-beta.2!

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

wlingke added 2 commits February 24, 2018 13:31

Ability to turn off analytics-node --- Addresses #116
80e2ea7

typos
d5a77b8

wlingke mentioned this pull request Feb 24, 2018
Ability to turn off analytics-node #116
Closed

vadimdemedes reviewed Feb 26, 2018
View reviewed changes

minor
59b7e62

Update test.js
662fec7

vadimdemedes approved these changes Feb 28, 2018
View reviewed changes

vadimdemedes merged commit 98821ef into segmentio:masterFeb 28, 2018

lukehesluke mentioned this pull request Apr 1, 2019
Add enable option to docs #205
Closed

Uh oh!

Conversation

wlingke commented Feb 24, 2018

Uh oh!

codecov-io commented Feb 24, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vadimdemedesFeb 26, 2018

Choose a reason for hiding this comment

Uh oh!

wlingke commented Feb 26, 2018 via email

Uh oh!

vadimdemedes commented Feb 27, 2018

Uh oh!

wlingke commented Feb 27, 2018

Uh oh!

vadimdemedes commented Feb 28, 2018

Uh oh!

f2prateek commented Mar 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wlingke commented Feb 24, 2018

Uh oh!

codecov-io commented Feb 24, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vadimdemedesFeb 26, 2018

Choose a reason for hiding this comment

Uh oh!

wlingke commented Feb 26, 2018 via email

Uh oh!

vadimdemedes commented Feb 27, 2018

Uh oh!

wlingke commented Feb 27, 2018

Uh oh!

vadimdemedes commented Feb 28, 2018

Uh oh!

f2prateek commented Mar 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wlingke commented Feb 24, 2018

Uh oh!

codecov-io commented Feb 24, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vadimdemedesFeb 26, 2018

Choose a reason for hiding this comment

Uh oh!

wlingke commented Feb 26, 2018 via email

Uh oh!

vadimdemedes commented Feb 27, 2018

Uh oh!

wlingke commented Feb 27, 2018

Uh oh!

vadimdemedes commented Feb 28, 2018

Uh oh!

f2prateek commented Mar 3, 2018

Uh oh!

Reviewers

codecov-io commented Feb 24, 2018•
edited
Loading

codecov-io commented Feb 24, 2018•
edited
Loading

codecov-io commented Feb 24, 2018•
edited
Loading

codecov-io commented Feb 24, 2018•
edited
Loading

codecov-io commented Feb 24, 2018•
edited
Loading