Uh oh!
There was an error while loading. Please reload this page.
make user id nullable in line with java interface - #140
Closed
aultimus wants to merge 1 commit into
Closed
Conversation
aultimusforce-pushed
the
make-userid-nullable
branch
from
March 10, 2020 23:11
841f30b to
1dbf451Compare
aultimusforce-pushed
the
make-userid-nullable
branch
from
March 10, 2020 23:13
1dbf451 to
25c1931Comparebsneed
commented
Mar 11, 2020
Contributor
Can you verify that all the other nullability settings in this file are correct? |
bsneed
commented
Mar 19, 2020
Contributor
This is addressed in PR #147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal issue https://segment.atlassian.net/browse/LIB-1639
function definition disagreed with java on nullability of userId https://github.com/segmentio/analytics-android/blob/master/analytics/src/main/java/com/segment/analytics/Analytics.java#L440