Uh oh!
There was an error while loading. Please reload this page.
Refactor: Move dequeue outside loop for efficiency - #142
Closed
sebapastore wants to merge 1 commit into
Closed
Conversation
neelkanth-kaushik
commented
May 23, 2025
Contributor
Hello @sebapastore , Thanks for your suggestions. We have created a single Pull Request #162 with your changes in this PR as well as PR #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved
_queuePlugin.dequeue(sentEvents)outside the Future.forEach loop to run once after all batches, instead of dequeuing already dequeued events per iteration.