Skip to content

add support for embedding struct configuration with special "_" tag - #23

Merged
stevevls merged 3 commits into
masterfrom
embedded_structs
May 10, 2018
Merged

add support for embedding struct configuration with special "_" tag#23
stevevls merged 3 commits into
masterfrom
embedded_structs

Conversation

@stevevls

@stevevls stevevls commented May 9, 2018

Copy link
Copy Markdown
Contributor

Issue #22

@stevevls

stevevls commented May 9, 2018

Copy link
Copy Markdown
Contributor Author

First pass at the proposal to use _ as the special tag to embed structs. LMK what looks good and what doesn't.

@achille-roussel

Copy link
Copy Markdown
Contributor

This is looking great 💥

@stevevls

stevevls commented May 9, 2018

Copy link
Copy Markdown
Contributor Author

Awesome! I added a couple more test cases and squashed a couple of bugs. I also searched the project for anywhere we were doing field.Tag.Get("conf") to make sure that I wasn't missing any additional spots where we're inspecting the tag. I only come up with the two places: one in makeNodeStruct and the other in fieldPath. Let me know if there are any other places you can think of that need to be updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants