Skip to content

ci: remove dead registry-api notification workflow - #334

Open
alexander-sei wants to merge 1 commit into
mainfrom
chore/remove-registry-api-notify
Open

ci: remove dead registry-api notification workflow#334
alexander-sei wants to merge 1 commit into
mainfrom
chore/remove-registry-api-notify

Conversation

@alexander-sei

Copy link
Copy Markdown
Contributor

What

Deletes .github/workflows/notify.yml ("Update Registry Submodules").

Why

The workflow has never reached sei-protocol/registry-api.

  • peter-evans/repository-dispatch defaults its repository input to ${{ github.repository }}. The workflow never set repository:, in any version since Add notify workflow #165 introduced it. Every dispatch went to sei-protocol/sei-js, not registry-api.
  • It authenticates with secrets.GITHUB_TOKEN, which cannot create a dispatch in another repository even if one were named.
  • No workflow in sei-js or in registry-api subscribes to repository_dispatch. registry-api has no .github/ directory at all, so there was no receiver on either end.

The only observable effect was a runner and a 90 second sleep after every successful release.

registry-api is being retired separately. Its last commit is 2024-04-12, it is private, and no repository in the sei-protocol org references its endpoint. Its README still documents arctic-1, which this repo dropped in 96d9e1c.

Scope

CI only. No package source changes, so no changeset. @sei-js/registry is unaffected and continues to publish.

🤖 Generated with Claude Code

The "Update Registry Submodules" workflow has never reached
registry-api. peter-evans/repository-dispatch defaults `repository`
to ${{ github.repository }}, and the workflow never set it, so every
version since #165 dispatched into sei-js itself. It also used
secrets.GITHUB_TOKEN, which cannot dispatch across repositories.
No workflow in sei-js or registry-api listens for repository_dispatch,
so the event had no receiver either way. registry-api has had no
commits since 2024-04-12 and is being retired.
The workflow only cost a runner and a 90 second sleep on every release.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@cursor

cursorBot commented Aug 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Removes unused CI automation with no runtime or package behavior changes.

Overview
Removes the Update Registry Submodules GitHub Actions workflow (.github/workflows/notify.yml) that ran after a successful Release workflow.

That job waited 90 seconds, then fired a repository_dispatch with event type workflow_completed. It did not meaningfully integrate with registry-api (wrong target repo, token scope, and no receiver), so releases only paid for an extra runner and delay.

CI-only cleanup; publishing for @sei-js/registry and package source are unchanged.

Reviewed by Cursor Bugbot for commit d818cf9. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.82%. Comparing base (eff761b) to head (d818cf9).

Additional details and impacted files
@@ Coverage Diff @@## main #334 +/- ##
=======================================
Coverage 83.82% 83.82% =======================================
Files 64 64 Lines 4390 4390 =======================================
Hits 3680 3680 Misses 710 710 
FlagCoverage Δ
mcp-server77.28% <ø> (ø)
precompiles100.00% <ø> (ø)
registry100.00% <ø> (ø)
sei-global-wallet100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seidroidseidroidBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletes the inert .github/workflows/notify.yml; the PR's rationale checks out — the dispatch defaulted to this repo, GITHUB_TOKEN cannot dispatch cross-repo, and no repository_dispatch listener exists, so the job only ever burned a runner and a 90s sleep. CI-only with no dangling references, correctly needs no changeset; the sole note is that the Cursor pass produced no output.

Findings: 0 blocking | 2 non-blocking | 0 posted inline

Blockers

  • None at the file/PR level.

Non-blocking

  • The Cursor second-opinion review file (cursor-review.md) is empty, so that pass produced no output and contributed nothing to this synthesis. Codex reported no material issues; my own verification found none either.
  • Confirmed no changeset is needed: the change is CI-only with no published-package behaviour, type, or dependency impact, which matches §3 of REVIEW_GUIDELINES.md. @sei-js/registry still publishes via release.yml, which is untouched.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-sei@codecov-commenter