Adopt shared errorMessage() in agents.ts and templates.ts - #608
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
selfcontained added a commit
that referenced
this pull request
Aug 9, 2026
`apps/server/src/shared/lib/error-message.ts` is the canonical helper for turning an unknown catch value into a string, but 18 sites across 11 server modules had re-inlined `error instanceof Error ? error.message : String(error)` instead of importing it. This is a regression of the consolidation done in #608 — the pattern creeps back in every time a new try/catch is written. Replaced only byte-equivalent occurrences. Sites with a different fallback ("Unknown error", "Archive failed", "Invalid model.", the `.slice(0, 2_000)` truncation in browser-extension.ts) or a different result type (the variants that rethrow an `Error` rather than produce a string) are intentionally left alone — they are not the same function. No behavior change; `errorMessage()` is byte-identical to what each site inlined. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error instanceof Error ? error.message : "..."patterns inagents.tswith the sharederrorMessage()helper fromshared/lib/error-message.tstemplates.ts(which already imported the helper but wasn't using it everywhere)errorMessage()inpersonalities.tsWhy this is tech debt
The shared
errorMessage()helper was introduced specifically to eliminate this boilerplate. These 7 remaining inline instances were the last holdouts — using them inconsistently defeats the purpose of the shared helper and makes future changes (e.g., adding logging or changing the fallback behavior) require touching every file instead of one.What's next
Next tech-debt run will tackle the top backlog item: monitoring the
ide-settings.ts/agent-type-settings.tspattern similarity.🤖 Generated with Claude Code