Remove dead passthrough methods from AgentManager - #615
Merged
Conversation
getPersonaReviewsByParent and getReviewerRecheckContext had zero production callers — the underlying persona-reviews.ts functions remain available for direct use. Also removes the unused ReviewerRecheckContext type re-export and the orphaned test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPersonaReviewsByParentandgetReviewerRecheckContextpassthrough methods fromAgentManager— these had zero production callersReviewerRecheckContexttype re-exportgetReviewerRecheckContextpersona-reviews.tsremain available for direct useWhy this qualifies as tech debt
Dead passthrough methods inflate the
AgentManagerclass surface area and create the illusion of a required interface contract. Removing them clarifies which manager methods are actually depended on, making future decomposition of the class easier.Next run
The next tech debt run will continue
manager.tsdecomposition: the remaining ~170 lines of persona/feedback/telemetry passthrough methods that are used but could potentially be called directly on the underlying modules.🤖 Generated with Claude Code